net/url_request/url_request_ftp_job.cc - Issue 252003002: Fix WeakPtrFactory member order in net/url_request/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/url_request/url_request_ftp_job.cc

Issue 252003002: Fix WeakPtrFactory member order in net/url_request/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/url_request/url_request_ftp_job.cc

diff --git a/net/url_request/url_request_ftp_job.cc b/net/url_request/url_request_ftp_job.cc

index 939a226751ed652760e7e546777a76a95e7cfe75..fec144756122681cba070b0f60b29ee049e0c8e5 100644

--- a/net/url_request/url_request_ftp_job.cc

+++ b/net/url_request/url_request_ftp_job.cc

@@ -34,9 +34,9 @@ URLRequestFtpJob::URLRequestFtpJob(

pac_request_(NULL),

http_response_info_(NULL),

read_in_progress_(false),

- weak_factory_(this),

ftp_transaction_factory_(ftp_transaction_factory),

- ftp_auth_cache_(ftp_auth_cache) {

+ ftp_auth_cache_(ftp_auth_cache),

+ weak_factory_(this) {

DCHECK(proxy_service_);

DCHECK(ftp_transaction_factory);

DCHECK(ftp_auth_cache);

« no previous file with comments | « net/url_request/url_request_ftp_job.h ('k') | net/url_request/url_request_http_job.h » ('j') | no next file with comments »