Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(812)

Unified Diff: net/url_request/url_request_http_job.h

Issue 252003002: Fix WeakPtrFactory member order in net/url_request/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/url_request/url_request_ftp_job.cc ('k') | net/url_request/url_request_http_job.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/url_request/url_request_http_job.h
diff --git a/net/url_request/url_request_http_job.h b/net/url_request/url_request_http_job.h
index d5aa5ba5918f5893d48a75d86aaa85966390a36a..b7ac50cc60cc089a92e77f8d42be68ca1ef94df7 100644
--- a/net/url_request/url_request_http_job.h
+++ b/net/url_request/url_request_http_job.h
@@ -248,7 +248,6 @@ class NET_EXPORT_PRIVATE URLRequestHttpJob : public URLRequestJob {
base::TimeTicks receive_headers_end_;
scoped_ptr<HttpFilterContext> filter_context_;
- base::WeakPtrFactory<URLRequestHttpJob> weak_factory_;
CompletionCallback on_headers_received_callback_;
@@ -271,6 +270,8 @@ class NET_EXPORT_PRIVATE URLRequestHttpJob : public URLRequestJob {
const HttpUserAgentSettings* http_user_agent_settings_;
+ base::WeakPtrFactory<URLRequestHttpJob> weak_factory_;
+
DISALLOW_COPY_AND_ASSIGN(URLRequestHttpJob);
};
« no previous file with comments | « net/url_request/url_request_ftp_job.cc ('k') | net/url_request/url_request_http_job.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698