Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(790)

Unified Diff: net/url_request/url_fetcher_response_writer.h

Issue 252003002: Fix WeakPtrFactory member order in net/url_request/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « AUTHORS ('k') | net/url_request/url_fetcher_response_writer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/url_request/url_fetcher_response_writer.h
diff --git a/net/url_request/url_fetcher_response_writer.h b/net/url_request/url_fetcher_response_writer.h
index 422a8a400adbfa76aeb5f17929c13b313260dbed..651e95c619ec8336cef08b525ce07bc1583533f1 100644
--- a/net/url_request/url_fetcher_response_writer.h
+++ b/net/url_request/url_fetcher_response_writer.h
@@ -119,9 +119,6 @@ class NET_EXPORT URLFetcherFileWriter : public URLFetcherResponseWriter {
// Callback which gets the result of closing a file.
void CloseComplete(const CompletionCallback& callback, int result);
- // Callbacks are created for use with base::FileUtilProxy.
- base::WeakPtrFactory<URLFetcherFileWriter> weak_factory_;
-
// Task runner on which file operations should happen.
scoped_refptr<base::SequencedTaskRunner> file_task_runner_;
@@ -134,6 +131,9 @@ class NET_EXPORT URLFetcherFileWriter : public URLFetcherResponseWriter {
scoped_ptr<FileStream> file_stream_;
+ // Callbacks are created for use with base::FileUtilProxy.
+ base::WeakPtrFactory<URLFetcherFileWriter> weak_factory_;
+
DISALLOW_COPY_AND_ASSIGN(URLFetcherFileWriter);
};
« no previous file with comments | « AUTHORS ('k') | net/url_request/url_fetcher_response_writer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698