Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Side by Side Diff: net/url_request/url_request_http_job.cc

Issue 252003002: Fix WeakPtrFactory member order in net/url_request/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « net/url_request/url_request_http_job.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "net/url_request/url_request_http_job.h" 5 #include "net/url_request/url_request_http_job.h"
6 6
7 #include "base/base_switches.h" 7 #include "base/base_switches.h"
8 #include "base/bind.h" 8 #include "base/bind.h"
9 #include "base/bind_helpers.h" 9 #include "base/bind_helpers.h"
10 #include "base/command_line.h" 10 #include "base/command_line.h"
(...skipping 175 matching lines...) Expand 10 before | Expand all | Expand 10 after
186 sdch_test_activated_(false), 186 sdch_test_activated_(false),
187 sdch_test_control_(false), 187 sdch_test_control_(false),
188 is_cached_content_(false), 188 is_cached_content_(false),
189 request_creation_time_(), 189 request_creation_time_(),
190 packet_timing_enabled_(false), 190 packet_timing_enabled_(false),
191 done_(false), 191 done_(false),
192 bytes_observed_in_packets_(0), 192 bytes_observed_in_packets_(0),
193 request_time_snapshot_(), 193 request_time_snapshot_(),
194 final_packet_time_(), 194 final_packet_time_(),
195 filter_context_(new HttpFilterContext(this)), 195 filter_context_(new HttpFilterContext(this)),
196 weak_factory_(this),
197 on_headers_received_callback_( 196 on_headers_received_callback_(
198 base::Bind(&URLRequestHttpJob::OnHeadersReceivedCallback, 197 base::Bind(&URLRequestHttpJob::OnHeadersReceivedCallback,
199 base::Unretained(this))), 198 base::Unretained(this))),
200 awaiting_callback_(false), 199 awaiting_callback_(false),
201 http_user_agent_settings_(http_user_agent_settings) { 200 http_user_agent_settings_(http_user_agent_settings),
201 weak_factory_(this) {
202 URLRequestThrottlerManager* manager = request->context()->throttler_manager(); 202 URLRequestThrottlerManager* manager = request->context()->throttler_manager();
203 if (manager) 203 if (manager)
204 throttling_entry_ = manager->RegisterRequestUrl(request->url()); 204 throttling_entry_ = manager->RegisterRequestUrl(request->url());
205 205
206 ResetTimer(); 206 ResetTimer();
207 } 207 }
208 208
209 URLRequestHttpJob::~URLRequestHttpJob() { 209 URLRequestHttpJob::~URLRequestHttpJob() {
210 CHECK(!awaiting_callback_); 210 CHECK(!awaiting_callback_);
211 211
(...skipping 1292 matching lines...) Expand 10 before | Expand all | Expand 10 after
1504 return override_response_headers_.get() ? 1504 return override_response_headers_.get() ?
1505 override_response_headers_.get() : 1505 override_response_headers_.get() :
1506 transaction_->GetResponseInfo()->headers.get(); 1506 transaction_->GetResponseInfo()->headers.get();
1507 } 1507 }
1508 1508
1509 void URLRequestHttpJob::NotifyURLRequestDestroyed() { 1509 void URLRequestHttpJob::NotifyURLRequestDestroyed() {
1510 awaiting_callback_ = false; 1510 awaiting_callback_ = false;
1511 } 1511 }
1512 1512
1513 } // namespace net 1513 } // namespace net
OLDNEW
« no previous file with comments | « net/url_request/url_request_http_job.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698