Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Side by Side Diff: net/url_request/url_request_http_job.h

Issue 252003002: Fix WeakPtrFactory member order in net/url_request/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « net/url_request/url_request_ftp_job.cc ('k') | net/url_request/url_request_http_job.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef NET_URL_REQUEST_URL_REQUEST_HTTP_JOB_H_ 5 #ifndef NET_URL_REQUEST_URL_REQUEST_HTTP_JOB_H_
6 #define NET_URL_REQUEST_URL_REQUEST_HTTP_JOB_H_ 6 #define NET_URL_REQUEST_URL_REQUEST_HTTP_JOB_H_
7 7
8 #include <string> 8 #include <string>
9 #include <vector> 9 #include <vector>
10 10
(...skipping 230 matching lines...) Expand 10 before | Expand all | Expand 10 after
241 // last time for use in histograms. 241 // last time for use in histograms.
242 base::Time final_packet_time_; 242 base::Time final_packet_time_;
243 243
244 // The start time for the job, ignoring re-starts. 244 // The start time for the job, ignoring re-starts.
245 base::TimeTicks start_time_; 245 base::TimeTicks start_time_;
246 246
247 // When the transaction finished reading the request headers. 247 // When the transaction finished reading the request headers.
248 base::TimeTicks receive_headers_end_; 248 base::TimeTicks receive_headers_end_;
249 249
250 scoped_ptr<HttpFilterContext> filter_context_; 250 scoped_ptr<HttpFilterContext> filter_context_;
251 base::WeakPtrFactory<URLRequestHttpJob> weak_factory_;
252 251
253 CompletionCallback on_headers_received_callback_; 252 CompletionCallback on_headers_received_callback_;
254 253
255 // We allow the network delegate to modify a copy of the response headers. 254 // We allow the network delegate to modify a copy of the response headers.
256 // This prevents modifications of headers that are shared with the underlying 255 // This prevents modifications of headers that are shared with the underlying
257 // layers of the network stack. 256 // layers of the network stack.
258 scoped_refptr<HttpResponseHeaders> override_response_headers_; 257 scoped_refptr<HttpResponseHeaders> override_response_headers_;
259 258
260 // The network delegate can mark a URL as safe for redirection. 259 // The network delegate can mark a URL as safe for redirection.
261 // The reference fragment of the original URL is not appended to the redirect 260 // The reference fragment of the original URL is not appended to the redirect
262 // URL when the redirect URL is equal to |allowed_unsafe_redirect_url_|. 261 // URL when the redirect URL is equal to |allowed_unsafe_redirect_url_|.
263 GURL allowed_unsafe_redirect_url_; 262 GURL allowed_unsafe_redirect_url_;
264 263
265 // Flag used to verify that |this| is not deleted while we are awaiting 264 // Flag used to verify that |this| is not deleted while we are awaiting
266 // a callback from the NetworkDelegate. Used as a fail-fast mechanism. 265 // a callback from the NetworkDelegate. Used as a fail-fast mechanism.
267 // True if we are waiting a callback and 266 // True if we are waiting a callback and
268 // NetworkDelegate::NotifyURLRequestDestroyed has not been called, yet, 267 // NetworkDelegate::NotifyURLRequestDestroyed has not been called, yet,
269 // to inform the NetworkDelegate that it may not call back. 268 // to inform the NetworkDelegate that it may not call back.
270 bool awaiting_callback_; 269 bool awaiting_callback_;
271 270
272 const HttpUserAgentSettings* http_user_agent_settings_; 271 const HttpUserAgentSettings* http_user_agent_settings_;
273 272
273 base::WeakPtrFactory<URLRequestHttpJob> weak_factory_;
274
274 DISALLOW_COPY_AND_ASSIGN(URLRequestHttpJob); 275 DISALLOW_COPY_AND_ASSIGN(URLRequestHttpJob);
275 }; 276 };
276 277
277 } // namespace net 278 } // namespace net
278 279
279 #endif // NET_URL_REQUEST_URL_REQUEST_HTTP_JOB_H_ 280 #endif // NET_URL_REQUEST_URL_REQUEST_HTTP_JOB_H_
OLDNEW
« no previous file with comments | « net/url_request/url_request_ftp_job.cc ('k') | net/url_request/url_request_http_job.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698