Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2512873002: [DevTools] Do not use external links for resources anymore. (Closed)

Created:
4 years, 1 month ago by dgozman
Modified:
4 years, 1 month ago
Reviewers:
lushnikov
CC:
chromium-reviews, caseq+blink_chromium.org, blink-reviews-style_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Do not use external links for resources anymore. We figure out whether the link is external vs. resource when clicking or showing context menu. BUG=665661 Committed: https://crrev.com/ec36eece79b9b54ea488826cfc175ab985362e10 Cr-Commit-Position: refs/heads/master@{#433397}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -74 lines) Patch
M third_party/WebKit/LayoutTests/http/tests/inspector/elements/elements-linkify-attributes-expected.txt View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/console/console-log-linkify-links.html View 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/console/console-log-linkify-links-expected.txt View 1 chunk +10 lines, -5 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/console/console-log-linkify-stack-in-errors-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/audits/AuditFormatters.js View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/audits/AuditsPanel.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/components/Linkifier.js View 5 chunks +24 lines, -43 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeElement.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/resources/AppManifestView.js View 2 chunks +3 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/resources/ServiceWorkersView.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js View 4 chunks +5 lines, -5 lines 0 comments Download

Depends on Patchset:

Issue 2515543002 Patch 1

Dependent Patchsets:

Issue 2510193003 Patch 1
Issue 2510193003 Patch 20001
Issue 2510193003 Patch 40001

Messages

Total messages: 8 (3 generated)
dgozman
Take a look please.
4 years, 1 month ago (2016-11-18 00:43:36 UTC) #2
lushnikov
lgtm
4 years, 1 month ago (2016-11-18 00:59:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2512873002/1
4 years, 1 month ago (2016-11-19 02:34:26 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-19 04:15:27 UTC) #6
commit-bot: I haz the power
4 years, 1 month ago (2016-11-19 04:19:45 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/ec36eece79b9b54ea488826cfc175ab985362e10
Cr-Commit-Position: refs/heads/master@{#433397}

Powered by Google App Engine
This is Rietveld 408576698