Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(892)

Unified Diff: third_party/WebKit/Source/devtools/front_end/resources/AppManifestView.js

Issue 2512873002: [DevTools] Do not use external links for resources anymore. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/resources/AppManifestView.js
diff --git a/third_party/WebKit/Source/devtools/front_end/resources/AppManifestView.js b/third_party/WebKit/Source/devtools/front_end/resources/AppManifestView.js
index 23d3ba453b3f99d7104abb8de4c16d8ee229a0e5..97f7c84f982da70ac3cdcbe02876d07e01cea2c4 100644
--- a/third_party/WebKit/Source/devtools/front_end/resources/AppManifestView.js
+++ b/third_party/WebKit/Source/devtools/front_end/resources/AppManifestView.js
@@ -81,7 +81,7 @@ Resources.AppManifestView = class extends UI.VBox {
* @param {!Array<!Protocol.Page.AppManifestError>} errors
*/
_renderManifest(url, data, errors) {
- this._reportView.setURL(Components.Linkifier.linkifyURLAsNode(url));
+ this._reportView.setURL(Components.Linkifier.linkifyURL(url));
this._errorsSection.clearContent();
this._errorsSection.element.classList.toggle('hidden', !errors.length);
for (var error of errors) {
@@ -98,9 +98,8 @@ Resources.AppManifestView = class extends UI.VBox {
this._startURLField.removeChildren();
var startURL = stringProperty('start_url');
if (startURL) {
- this._startURLField.appendChild(Components.linkifyResourceAsNode(
- /** @type {string} */ (Common.ParsedURL.completeURL(url, startURL)), undefined, undefined, undefined,
- undefined, startURL));
+ this._startURLField.appendChild(Components.Linkifier.linkifyURL(
+ /** @type {string} */ (Common.ParsedURL.completeURL(url, startURL)), startURL));
}
this._themeColorSwatch.classList.toggle('hidden', !stringProperty('theme_color'));

Powered by Google App Engine
This is Rietveld 408576698