third_party/WebKit/Source/devtools/front_end/audits/AuditFormatters.js - Issue 2512873002: [DevTools] Do not use external links for resources anymore.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/audits/AuditFormatters.js

Issue 2512873002: [DevTools] Do not use external links for resources anymore. (Closed)

Patch Set: Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/inspector/console/console-log-linkify-stack-in-errors-expected.txt ('k') | third_party/WebKit/Source/devtools/front_end/audits/AuditsPanel.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/audits/AuditFormatters.js

diff --git a/third_party/WebKit/Source/devtools/front_end/audits/AuditFormatters.js b/third_party/WebKit/Source/devtools/front_end/audits/AuditFormatters.js

index 90082ec9f7527849a4c093137f4b601bc6bac080..ac4c1eb731bd3caa3c883d6636b550bfc52b649e 100644

--- a/third_party/WebKit/Source/devtools/front_end/audits/AuditFormatters.js

+++ b/third_party/WebKit/Source/devtools/front_end/audits/AuditFormatters.js

@@ -127,8 +127,7 @@ Audits.AuditFormatters.Registry = {

* @return {!Element}

resourceLink: function(url, line) {

- // FIXME: use Components.Linkifier

- return Components.linkifyResourceAsNode(url, line, undefined, 'resource-url webkit-html-resource-link');

+ return Components.Linkifier.linkifyURL(url, undefined, 'resource-url', line);

}

};