Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(741)

Unified Diff: third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js

Issue 2512873002: [DevTools] Do not use external links for resources anymore. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/resources/ServiceWorkersView.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js
diff --git a/third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js b/third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js
index bb5a60dca8f3e513e47ad38979e3c4f51b1e33b6..cf95e4c76472014e222830a7095e5891ec0e5212 100644
--- a/third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js
+++ b/third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js
@@ -605,7 +605,7 @@ Timeline.TimelineUIUtils = class {
case recordType.ResourceFinish:
var url = TimelineModel.TimelineData.forEvent(event).url;
if (url)
- details = Components.linkifyResourceAsNode(url);
+ details = Components.Linkifier.linkifyURL(url);
break;
case recordType.FunctionCall:
case recordType.JSFrame:
@@ -782,7 +782,7 @@ Timeline.TimelineUIUtils = class {
case recordTypes.ResourceFinish:
var url = timelineData.url;
if (url)
- contentHelper.appendElementRow(Common.UIString('Resource'), Components.linkifyResourceAsNode(url));
+ contentHelper.appendElementRow(Common.UIString('Resource'), Components.Linkifier.linkifyURL(url));
if (eventData['requestMethod'])
contentHelper.appendTextRow(Common.UIString('Request Method'), eventData['requestMethod']);
if (typeof eventData['statusCode'] === 'number')
@@ -827,13 +827,13 @@ Timeline.TimelineUIUtils = class {
relatedNodeLabel = Common.UIString('Owner Element');
if (timelineData.url) {
contentHelper.appendElementRow(
- Common.UIString('Image URL'), Components.linkifyResourceAsNode(timelineData.url));
+ Common.UIString('Image URL'), Components.Linkifier.linkifyURL(timelineData.url));
}
break;
case recordTypes.ParseAuthorStyleSheet:
var url = eventData['styleSheetUrl'];
if (url)
- contentHelper.appendElementRow(Common.UIString('Stylesheet URL'), Components.linkifyResourceAsNode(url));
+ contentHelper.appendElementRow(Common.UIString('Stylesheet URL'), Components.Linkifier.linkifyURL(url));
break;
case recordTypes.UpdateLayoutTree: // We don't want to see default details.
case recordTypes.RecalculateStyles:
@@ -1025,7 +1025,7 @@ Timeline.TimelineUIUtils = class {
var duration = request.endTime - (request.startTime || -Infinity);
var items = [];
if (request.url)
- contentHelper.appendElementRow(Common.UIString('URL'), Components.Linkifier.linkifyURLAsNode(request.url));
+ contentHelper.appendElementRow(Common.UIString('URL'), Components.Linkifier.linkifyURL(request.url));
if (isFinite(duration))
contentHelper.appendTextRow(Common.UIString('Duration'), Number.millisToString(duration, true));
if (request.requestMethod)
« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/resources/ServiceWorkersView.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698