Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(475)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2510193003: [DevTools] Move link click and context menu handling to Linkifier. (Closed)

Created:
4 years, 1 month ago by dgozman
Modified:
4 years, 1 month ago
Reviewers:
lushnikov
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Move link click and context menu handling to Linkifier. BUG=665661 Committed: https://crrev.com/66cf403e747dc5dd959f9ee94852b269c0f3a312 Cr-Commit-Position: refs/heads/master@{#433416}

Patch Set 1 #

Total comments: 3

Patch Set 2 : rework #

Total comments: 4

Patch Set 3 : fixed comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+109 lines, -113 lines) Patch
M third_party/WebKit/Source/devtools/front_end/components/HandlerRegistry.js View 2 chunks +0 lines, -48 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/components/Linkifier.js View 1 2 4 chunks +98 lines, -16 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/main/Main.js View 1 2 2 chunks +0 lines, -47 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/main/module.json View 2 chunks +6 lines, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/platform/DOMExtension.js View 1 chunk +5 lines, -1 line 0 comments Download

Depends on Patchset:

Issue 2512873002 Patch 1

Dependent Patchsets:

Issue 2512353002 Patch 1

Messages

Total messages: 12 (4 generated)
dgozman
Could you please take a look?
4 years, 1 month ago (2016-11-18 01:36:20 UTC) #2
lushnikov
lgtm https://codereview.chromium.org/2510193003/diff/1/third_party/WebKit/Source/devtools/front_end/components/HandlerRegistry.js File third_party/WebKit/Source/devtools/front_end/components/HandlerRegistry.js (left): https://codereview.chromium.org/2510193003/diff/1/third_party/WebKit/Source/devtools/front_end/components/HandlerRegistry.js#oldcode171 third_party/WebKit/Source/devtools/front_end/components/HandlerRegistry.js:171: var uiLocation = Components.Linkifier.uiLocationByAnchor(anchorElement); "I lost this!" (Dmitry) ...
4 years, 1 month ago (2016-11-18 01:57:40 UTC) #3
dgozman
PTAL https://codereview.chromium.org/2510193003/diff/1/third_party/WebKit/Source/devtools/front_end/components/HandlerRegistry.js File third_party/WebKit/Source/devtools/front_end/components/HandlerRegistry.js (left): https://codereview.chromium.org/2510193003/diff/1/third_party/WebKit/Source/devtools/front_end/components/HandlerRegistry.js#oldcode171 third_party/WebKit/Source/devtools/front_end/components/HandlerRegistry.js:171: var uiLocation = Components.Linkifier.uiLocationByAnchor(anchorElement); On 2016/11/18 01:57:40, lushnikov ...
4 years, 1 month ago (2016-11-18 02:58:45 UTC) #4
lushnikov
https://codereview.chromium.org/2510193003/diff/20001/third_party/WebKit/Source/devtools/front_end/components/Linkifier.js File third_party/WebKit/Source/devtools/front_end/components/Linkifier.js (right): https://codereview.chromium.org/2510193003/diff/20001/third_party/WebKit/Source/devtools/front_end/components/Linkifier.js#newcode479 third_party/WebKit/Source/devtools/front_end/components/Linkifier.js:479: actions[0].handler(); nit: consider actions[0].handler.call(null) to avoid leaking action https://codereview.chromium.org/2510193003/diff/20001/third_party/WebKit/Source/devtools/front_end/components/Linkifier.js#newcode484 ...
4 years, 1 month ago (2016-11-18 23:43:35 UTC) #5
dgozman
https://codereview.chromium.org/2510193003/diff/20001/third_party/WebKit/Source/devtools/front_end/components/Linkifier.js File third_party/WebKit/Source/devtools/front_end/components/Linkifier.js (right): https://codereview.chromium.org/2510193003/diff/20001/third_party/WebKit/Source/devtools/front_end/components/Linkifier.js#newcode479 third_party/WebKit/Source/devtools/front_end/components/Linkifier.js:479: actions[0].handler(); On 2016/11/18 23:43:35, lushnikov wrote: > nit: consider ...
4 years, 1 month ago (2016-11-19 02:09:47 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2510193003/40001
4 years, 1 month ago (2016-11-19 07:29:21 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 1 month ago (2016-11-19 09:11:59 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-11-19 09:13:43 UTC) #12
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/66cf403e747dc5dd959f9ee94852b269c0f3a312
Cr-Commit-Position: refs/heads/master@{#433416}

Powered by Google App Engine
This is Rietveld 408576698