Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2515543002: [DevTools] Remove Components.linkifyRequestAsNode. (Closed)

Created:
4 years, 1 month ago by dgozman
Modified:
4 years, 1 month ago
Reviewers:
lushnikov
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Remove Components.linkifyRequestAsNode. It is used in one place and doesn't really bring any functionality. BUG=665661 Committed: https://crrev.com/9d93d2db99cd8b188713f7433cbeff15394f8f17 Cr-Commit-Position: refs/heads/master@{#433385}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -11 lines) Patch
M third_party/WebKit/Source/devtools/front_end/components/Linkifier.js View 1 chunk +0 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Issue 2512013002 Patch 20001

Dependent Patchsets:

Issue 2512873002 Patch 1

Messages

Total messages: 8 (3 generated)
dgozman
Take a look please.
4 years, 1 month ago (2016-11-17 23:24:12 UTC) #2
lushnikov
lgtm
4 years, 1 month ago (2016-11-18 00:47:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2515543002/1
4 years, 1 month ago (2016-11-18 23:43:59 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-19 02:29:47 UTC) #6
commit-bot: I haz the power
4 years, 1 month ago (2016-11-19 02:39:01 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/9d93d2db99cd8b188713f7433cbeff15394f8f17
Cr-Commit-Position: refs/heads/master@{#433385}

Powered by Google App Engine
This is Rietveld 408576698