Move enum MenuAnchorPosition to reduce deps on menu_item_view.h

Move enum MenuAnchorPosition to reduce deps on menu_item_view.h

[Menu]AnchorPosition is used by the MenuRunner and other APIs. Having
the enum nested in MenuItemView means that a lot of files must depend on
menu_item_view.h, even if they are just using a MenuRunner created with
a MenuModel (rather than a MenuItemView).

This CL moves the MenuItemView::AnchorPosition enum to
views::MenuAnchorPosition in menu_types.h. This allows the
menu_item_view.h dependency to be removed from a lot of places
(directly, and transitively by removing menu_item_view.h includes from
any header files).

BUG=366007, 363889
TBR=pfeldman@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=267471

[tapted, 2014-04-29 11:53:13]

Hi sky could you please take a look?

I kept dancing around this dependency, so decided just to try this out.

Note I'm not sure that ui_base_types.h is the best place for this (although it
does put it next to MenuSourceType which feels nice). Another option might be to
merge it with ui/base/models/menu_separator_types.h and call it menu_types.h or
similar).

The change is mostly mechanical (formatting courtesy of clang-format) or IWYU
adjustments - I've linked to the main interesting bits.

https://codereview.chromium.org/250943008/diff/100001/ui/base/ui_base_types.h
File ui/base/ui_base_types.h (right):

https://codereview.chromium.org/250943008/diff/100001/ui/base/ui_base_types.h...
ui/base/ui_base_types.h:72: #endif  // UI_BASE_UI_BASE_TYPES_H_
<link to interesting file>

https://codereview.chromium.org/250943008/diff/100001/ui/views/controls/menu/...
File ui/views/controls/menu/menu_item_view.h (left):

https://codereview.chromium.org/250943008/diff/100001/ui/views/controls/menu/...
ui/views/controls/menu/menu_item_view.h:100: 
<link to interesting bit>

[sky, 2014-04-29 15:30:56]

https://codereview.chromium.org/250943008/diff/100001/ui/base/ui_base_types.h
File ui/base/ui_base_types.h (right):

https://codereview.chromium.org/250943008/diff/100001/ui/base/ui_base_types.h...
ui/base/ui_base_types.h:60: enum MenuAnchorPosition {
I'm fine with moving MenuAnchorPosition, but it's view specific. Maybe
ui/views/controls/menu/menu_types.h.

[tapted, 2014-04-30 08:32:55]

Thanks sky - PTAL.

https://codereview.chromium.org/250943008/diff/100001/ui/base/ui_base_types.h
File ui/base/ui_base_types.h (right):

https://codereview.chromium.org/250943008/diff/100001/ui/base/ui_base_types.h...
ui/base/ui_base_types.h:60: enum MenuAnchorPosition {
On 2014/04/29 15:30:57, sky wrote:
> I'm fine with moving MenuAnchorPosition, but it's view specific. Maybe
> ui/views/controls/menu/menu_types.h.

Done.

https://codereview.chromium.org/250943008/diff/200001/ui/views/controls/menu/...
File ui/views/controls/menu/menu_types.h (right):

https://codereview.chromium.org/250943008/diff/200001/ui/views/controls/menu/...
ui/views/controls/menu/menu_types.h:26: #endif  //
UI_VIEWS_CONTROLS_MENU_MENU_TYPES_H_
<link to new file>

[sky, 2014-04-30 17:03:43]

LGTM

[tapted, 2014-05-01 00:11:31]

Thanks sky!

+pfeldman TBR for refactoring change in content/shell/browser/shell_views.cc

https://codereview.chromium.org/250943008/diff/200001/content/shell/browser/s...
File content/shell/browser/shell_views.cc (right):

https://codereview.chromium.org/250943008/diff/200001/content/shell/browser/s...
content/shell/browser/shell_views.cc:197: return;
just noticed a wrong indent here (this was outside the diff, so clang-format
missed it). Fixed.

[tapted, 2014-05-01 00:11:48]

The CQ bit was checked by tapted@chromium.org

[commit-bot: I haz the power, 2014-05-01 00:14:42]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tapted@chromium.org/250943008/240001

[commit-bot: I haz the power, 2014-05-01 01:43:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-01 01:44:00]

Try jobs failed on following builders:
  mac_chromium_rel on tryserver.chromium

[tapted, 2014-05-01 03:50:53]

The CQ bit was checked by tapted@chromium.org

[commit-bot: I haz the power, 2014-05-01 03:51:46]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tapted@chromium.org/250943008/240001

[commit-bot: I haz the power, 2014-05-01 07:50:44]

Change committed as 267471