chrome/browser/ui/views/download/download_shelf_context_menu_view.cc - Issue 250943008: Move enum MenuAnchorPosition to reduce deps on menu_item_view.h

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/download/download_shelf_context_menu_view.cc

Issue 250943008: Move enum MenuAnchorPosition to reduce deps on menu_item_view.h (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix indent Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/content_setting_bubble_contents.cc ('k') | chrome/browser/ui/views/extensions/browser_action_overflow_menu_controller.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/download/download_shelf_context_menu_view.cc

diff --git a/chrome/browser/ui/views/download/download_shelf_context_menu_view.cc b/chrome/browser/ui/views/download/download_shelf_context_menu_view.cc

index d65f7fd02c1e93490663639edab5385a38fc8f4d..570f3e3bea9589a89c61a2e10691a1994c36cf57 100644

--- a/chrome/browser/ui/views/download/download_shelf_context_menu_view.cc

+++ b/chrome/browser/ui/views/download/download_shelf_context_menu_view.cc

@@ -10,7 +10,6 @@

#include "content/public/browser/download_item.h"

#include "content/public/browser/page_navigator.h"

#include "ui/gfx/point.h"

-#include "ui/views/controls/menu/menu_item_view.h"

#include "ui/views/controls/menu/menu_runner.h"

DownloadShelfContextMenuView::DownloadShelfContextMenuView(

@@ -31,11 +30,11 @@ void DownloadShelfContextMenuView::Run(views::Widget* parent_widget,

menu_runner_.reset(new views::MenuRunner(menu_model));

// The menu's alignment is determined based on the UI layout.

- views::MenuItemView::AnchorPosition position;

+ views::MenuAnchorPosition position;

if (base::i18n::IsRTL())

- position = views::MenuItemView::TOPRIGHT;

+ position = views::MENU_ANCHOR_TOPRIGHT;

else

- position = views::MenuItemView::TOPLEFT;

+ position = views::MENU_ANCHOR_TOPLEFT;

// The return value of RunMenuAt indicates whether the MenuRunner was deleted

// while running the menu, which indicates that the containing view may have