Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Side by Side Diff: chrome/browser/ui/views/task_manager_view.cc

Issue 250943008: Move enum MenuAnchorPosition to reduce deps on menu_item_view.h (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix indent Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/task_manager/task_manager.h" 5 #include "chrome/browser/task_manager/task_manager.h"
6 6
7 #include "base/compiler_specific.h" 7 #include "base/compiler_specific.h"
8 #include "base/metrics/stats_table.h" 8 #include "base/metrics/stats_table.h"
9 #include "base/prefs/pref_service.h" 9 #include "base/prefs/pref_service.h"
10 #include "base/prefs/scoped_user_pref_update.h" 10 #include "base/prefs/scoped_user_pref_update.h"
(...skipping 576 matching lines...) Expand 10 before | Expand all | Expand 10 after
587 void TaskManagerView::ShowContextMenuForView(views::View* source, 587 void TaskManagerView::ShowContextMenuForView(views::View* source,
588 const gfx::Point& point, 588 const gfx::Point& point,
589 ui::MenuSourceType source_type) { 589 ui::MenuSourceType source_type) {
590 UpdateStatsCounters(); 590 UpdateStatsCounters();
591 ui::SimpleMenuModel menu_model(this); 591 ui::SimpleMenuModel menu_model(this);
592 for (std::vector<ui::TableColumn>::iterator i(columns_.begin()); 592 for (std::vector<ui::TableColumn>::iterator i(columns_.begin());
593 i != columns_.end(); ++i) { 593 i != columns_.end(); ++i) {
594 menu_model.AddCheckItem(i->id, l10n_util::GetStringUTF16(i->id)); 594 menu_model.AddCheckItem(i->id, l10n_util::GetStringUTF16(i->id));
595 } 595 }
596 menu_runner_.reset(new views::MenuRunner(&menu_model)); 596 menu_runner_.reset(new views::MenuRunner(&menu_model));
597 if (menu_runner_->RunMenuAt(GetWidget(), NULL, gfx::Rect(point, gfx::Size()), 597 if (menu_runner_->RunMenuAt(GetWidget(),
598 views::MenuItemView::TOPLEFT, source_type, 598 NULL,
599 gfx::Rect(point, gfx::Size()),
600 views::MENU_ANCHOR_TOPLEFT,
601 source_type,
599 views::MenuRunner::CONTEXT_MENU) == 602 views::MenuRunner::CONTEXT_MENU) ==
600 views::MenuRunner::MENU_DELETED) 603 views::MenuRunner::MENU_DELETED) {
601 return; 604 return;
605 }
602 } 606 }
603 607
604 bool TaskManagerView::IsCommandIdChecked(int id) const { 608 bool TaskManagerView::IsCommandIdChecked(int id) const {
605 return tab_table_->IsColumnVisible(id); 609 return tab_table_->IsColumnVisible(id);
606 } 610 }
607 611
608 bool TaskManagerView::IsCommandIdEnabled(int id) const { 612 bool TaskManagerView::IsCommandIdEnabled(int id) const {
609 return true; 613 return true;
610 } 614 }
611 615
(...skipping 32 matching lines...) Expand 10 before | Expand all | Expand 10 after
644 } // namespace 648 } // namespace
645 649
646 namespace chrome { 650 namespace chrome {
647 651
648 // Declared in browser_dialogs.h so others don't need to depend on our header. 652 // Declared in browser_dialogs.h so others don't need to depend on our header.
649 void ShowTaskManager(Browser* browser) { 653 void ShowTaskManager(Browser* browser) {
650 TaskManagerView::Show(browser); 654 TaskManagerView::Show(browser);
651 } 655 }
652 656
653 } // namespace chrome 657 } // namespace chrome
OLDNEW
« no previous file with comments | « chrome/browser/ui/views/tabs/browser_tab_strip_controller.cc ('k') | chrome/browser/ui/views/toolbar/browser_action_view.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698