Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8094)

Unified Diff: chrome/browser/ui/views/toolbar/toolbar_button.cc

Issue 250943008: Move enum MenuAnchorPosition to reduce deps on menu_item_view.h (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix indent Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/toolbar/toolbar_button.cc
diff --git a/chrome/browser/ui/views/toolbar/toolbar_button.cc b/chrome/browser/ui/views/toolbar/toolbar_button.cc
index bcbacd4dd0e15d01dc7247edff48e8d120306cf0..dad98d13bf9a4106a9268e14d919e5c0d03946cd 100644
--- a/chrome/browser/ui/views/toolbar/toolbar_button.cc
+++ b/chrome/browser/ui/views/toolbar/toolbar_button.cc
@@ -199,9 +199,10 @@ void ToolbarButton::ShowDropDownMenu(ui::MenuSourceType source_type) {
menu_delegate.set_triggerable_event_flags(triggerable_event_flags());
menu_runner_.reset(new views::MenuRunner(menu_delegate.CreateMenu()));
views::MenuRunner::RunResult result =
- menu_runner_->RunMenuAt(GetWidget(), NULL,
+ menu_runner_->RunMenuAt(GetWidget(),
+ NULL,
gfx::Rect(menu_position, gfx::Size(0, 0)),
- views::MenuItemView::TOPLEFT,
+ views::MENU_ANCHOR_TOPLEFT,
source_type,
views::MenuRunner::HAS_MNEMONICS);
if (result == views::MenuRunner::MENU_DELETED)
@@ -211,9 +212,10 @@ void ToolbarButton::ShowDropDownMenu(ui::MenuSourceType source_type) {
views::MenuItemView* menu = new views::MenuItemView(&menu_delegate);
menu_runner_.reset(new views::MenuRunner(menu));
views::MenuRunner::RunResult result =
- menu_runner_->RunMenuAt(GetWidget(), NULL,
+ menu_runner_->RunMenuAt(GetWidget(),
+ NULL,
gfx::Rect(menu_position, gfx::Size(0, 0)),
- views::MenuItemView::TOPLEFT,
+ views::MENU_ANCHOR_TOPLEFT,
source_type,
views::MenuRunner::HAS_MNEMONICS);
if (result == views::MenuRunner::MENU_DELETED)
« no previous file with comments | « chrome/browser/ui/views/toolbar/browser_action_view.cc ('k') | chrome/browser/ui/views/toolbar/wrench_menu.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698