chrome/browser/ui/views/website_settings/permission_selector_view.cc - Issue 250943008: Move enum MenuAnchorPosition to reduce deps on menu_item_view.h

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/website_settings/permission_selector_view.cc

Issue 250943008: Move enum MenuAnchorPosition to reduce deps on menu_item_view.h (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix indent Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/toolbar/wrench_menu.cc ('k') | chrome/browser/ui/views/website_settings/permissions_bubble_view.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/website_settings/permission_selector_view.cc

diff --git a/chrome/browser/ui/views/website_settings/permission_selector_view.cc b/chrome/browser/ui/views/website_settings/permission_selector_view.cc

index 11319fd1c6e54c9a1b512e3dfb07b777d6276f02..e8d28b5ad5f0d0ddc67de3d68c1d50f7a7894896 100644

--- a/chrome/browser/ui/views/website_settings/permission_selector_view.cc

+++ b/chrome/browser/ui/views/website_settings/permission_selector_view.cc

@@ -117,14 +117,15 @@ void PermissionMenuButton::OnMenuButtonClicked(View* source,

gfx::Point p(point);

p.Offset(-source->width(), 0);

- if (menu_runner_->RunMenuAt(

- source->GetWidget()->GetTopLevelWidget(),

- this,

- gfx::Rect(p, gfx::Size()),

- views::MenuItemView::TOPLEFT,

- ui::MENU_SOURCE_NONE,

- views::MenuRunner::HAS_MNEMONICS) == views::MenuRunner::MENU_DELETED)

+ if (menu_runner_->RunMenuAt(source->GetWidget()->GetTopLevelWidget(),

+ this,

+ gfx::Rect(p, gfx::Size()),

+ views::MENU_ANCHOR_TOPLEFT,

+ ui::MENU_SOURCE_NONE,

+ views::MenuRunner::HAS_MNEMONICS) ==

+ views::MenuRunner::MENU_DELETED) {

return;

+ }

}

} // namespace internal