Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7344)

Unified Diff: chrome/browser/ui/views/extensions/browser_action_overflow_menu_controller.cc

Issue 250943008: Move enum MenuAnchorPosition to reduce deps on menu_item_view.h (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix indent Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/extensions/browser_action_overflow_menu_controller.cc
diff --git a/chrome/browser/ui/views/extensions/browser_action_overflow_menu_controller.cc b/chrome/browser/ui/views/extensions/browser_action_overflow_menu_controller.cc
index 21041cb78119e2e16d2389f04fe63d92a45d3bc9..4bc75b8313ca1338d0164545806759fd3c672de1 100644
--- a/chrome/browser/ui/views/extensions/browser_action_overflow_menu_controller.cc
+++ b/chrome/browser/ui/views/extensions/browser_action_overflow_menu_controller.cc
@@ -112,7 +112,7 @@ bool BrowserActionOverflowMenuController::RunMenu(views::Widget* window,
bounds.set_x(screen_loc.x());
bounds.set_y(screen_loc.y());
- views::MenuItemView::AnchorPosition anchor = views::MenuItemView::TOPRIGHT;
+ views::MenuAnchorPosition anchor = views::MENU_ANCHOR_TOPRIGHT;
// As we maintain our own lifetime we can safely ignore the result.
ignore_result(menu_runner_->RunMenuAt(window, menu_button_, bounds, anchor,
ui::MENU_SOURCE_NONE, for_drop_ ? views::MenuRunner::FOR_DROP : 0));
@@ -154,11 +154,14 @@ bool BrowserActionOverflowMenuController::ShowContextMenu(
// We can ignore the result as we delete ourself.
// This blocks until the user choses something or dismisses the menu.
- ignore_result(context_menu_runner.RunMenuAt(menu_button_->GetWidget(),
- NULL, gfx::Rect(p, gfx::Size()), views::MenuItemView::TOPLEFT,
+ ignore_result(context_menu_runner.RunMenuAt(
+ menu_button_->GetWidget(),
+ NULL,
+ gfx::Rect(p, gfx::Size()),
+ views::MENU_ANCHOR_TOPLEFT,
source_type,
views::MenuRunner::HAS_MNEMONICS | views::MenuRunner::IS_NESTED |
- views::MenuRunner::CONTEXT_MENU));
+ views::MenuRunner::CONTEXT_MENU));
// The user is done with the context menu, so we can close the underlying
// menu.

Powered by Google App Engine
This is Rietveld 408576698