Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(241)

Issue 2508923003: Make printing work better with OOPIF. (try 2) (Closed)

Created:
4 years, 1 month ago by Lei Zhang
Modified:
3 years, 8 months ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, creis+watch_chromium.org, nasko+codewatch_chromium.org, jam, darin-cc_chromium.org, mac-reviews_chromium.org, android-webview-reviews_chromium.org, site-isolation-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make printing work better with OOPIF. (try 2) Fix failing Android WebView CTS tests this time. BUG=631513, 665909 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation TBR=nasko@chromium.org,rockot@chromium.org Committed: https://crrev.com/cb959ce66a9a89b6f100795bb33292439a7ed7de Cr-Commit-Position: refs/heads/master@{#432775}

Patch Set 1 : Original CL, r432353 #

Patch Set 2 : Fix android_webview #

Unified diffs Side-by-side diffs Delta from patch set Stats (+521 lines, -353 lines) Patch
M android_webview/browser/aw_print_manager.h View 1 chunk +7 lines, -2 lines 0 comments Download
M android_webview/browser/aw_print_manager.cc View 1 2 chunks +15 lines, -8 lines 0 comments Download
M android_webview/browser/aw_printing_message_filter.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M android_webview/browser/aw_printing_message_filter.cc View 1 4 chunks +11 lines, -12 lines 0 comments Download
M android_webview/renderer/aw_content_renderer_client.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M android_webview/renderer/aw_print_web_view_helper_delegate.h View 1 chunk +5 lines, -3 lines 0 comments Download
M android_webview/renderer/aw_print_web_view_helper_delegate.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M android_webview/renderer/print_render_frame_observer.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/android/tab_android.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/printing/print_preview_dialog_controller_browsertest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/printing/print_preview_dialog_controller_unittest.cc View 10 chunks +17 lines, -11 lines 0 comments Download
M chrome/browser/printing/print_preview_message_handler.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/printing/print_preview_message_handler.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/printing/print_view_manager.h View 5 chunks +16 lines, -11 lines 0 comments Download
M chrome/browser/printing/print_view_manager.cc View 8 chunks +60 lines, -29 lines 0 comments Download
M chrome/browser/printing/print_view_manager_base.h View 6 chunks +21 lines, -10 lines 0 comments Download
M chrome/browser/printing/print_view_manager_base.cc View 12 chunks +67 lines, -43 lines 0 comments Download
M chrome/browser/printing/print_view_manager_common.h View 2 chunks +6 lines, -1 line 0 comments Download
M chrome/browser/printing/print_view_manager_common.cc View 3 chunks +38 lines, -6 lines 0 comments Download
M chrome/browser/printing/printing_message_filter.h View 1 chunk +4 lines, -7 lines 0 comments Download
M chrome/browser/printing/printing_message_filter.cc View 5 chunks +15 lines, -20 lines 0 comments Download
M chrome/browser/ui/browser_commands.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M chrome/browser/ui/cocoa/applescript/tab_applescript.mm View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/print_preview/print_preview_handler.cc View 5 chunks +11 lines, -8 lines 0 comments Download
M chrome/browser/ui/webui/print_preview/print_preview_ui_unittest.cc View 4 chunks +4 lines, -3 lines 0 comments Download
M chrome/renderer/chrome_content_renderer_client.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/renderer/chrome_render_frame_observer.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/pepper/chrome_pdf_print_client.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M chrome/renderer/printing/chrome_print_web_view_helper_delegate.h View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/renderer/printing/chrome_print_web_view_helper_delegate.cc View 1 chunk +6 lines, -7 lines 0 comments Download
M components/printing/browser/print_manager.h View 1 chunk +3 lines, -2 lines 0 comments Download
M components/printing/browser/print_manager.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M components/printing/common/print_messages.h View 2 chunks +12 lines, -17 lines 0 comments Download
M components/printing/renderer/print_web_view_helper.h View 9 chunks +19 lines, -23 lines 0 comments Download
M components/printing/renderer/print_web_view_helper.cc View 14 chunks +54 lines, -70 lines 0 comments Download
M components/printing/test/print_test_content_renderer_client.h View 1 chunk +1 line, -1 line 0 comments Download
M components/printing/test/print_test_content_renderer_client.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M components/printing/test/print_web_view_helper_browsertest.cc View 7 chunks +17 lines, -12 lines 0 comments Download
M content/browser/frame_host/render_frame_host_impl.h View 2 chunks +4 lines, -0 lines 0 comments Download
M content/browser/frame_host/render_frame_host_impl.cc View 3 chunks +6 lines, -0 lines 0 comments Download
M content/public/browser/render_frame_host.h View 1 chunk +3 lines, -0 lines 0 comments Download
M content/public/renderer/render_frame_observer.h View 1 chunk +3 lines, -0 lines 0 comments Download
M content/public/renderer/render_view_observer.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/render_frame_impl.h View 1 chunk +2 lines, -0 lines 0 comments Download
M content/renderer/render_frame_impl.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M content/renderer/render_view_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ipc/ipc_message_macros.h View 2 chunks +17 lines, -0 lines 0 comments Download
M ipc/ipc_message_templates.h View 3 chunks +25 lines, -2 lines 0 comments Download

Messages

Total messages: 20 (13 generated)
Lei Zhang
sgurun: PTAL at the patch set 1 to 2 diff. The changes in android_webview/ are ...
4 years, 1 month ago (2016-11-17 03:30:34 UTC) #5
sgurun-gerrit only
On 2016/11/17 03:26:51, Lei Zhang (Mostly OOO) wrote: > The CQ bit was checked by ...
4 years, 1 month ago (2016-11-17 03:37:45 UTC) #6
Lei Zhang
Added TBR line for the rest. Will land when tryjobs finish.
4 years, 1 month ago (2016-11-17 03:41:45 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2508923003/20001
4 years, 1 month ago (2016-11-17 05:51:42 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-17 05:57:08 UTC) #14
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/cb959ce66a9a89b6f100795bb33292439a7ed7de Cr-Commit-Position: refs/heads/master@{#432775}
4 years, 1 month ago (2016-11-17 05:59:55 UTC) #16
ashleighnstevenb
3 years, 8 months ago (2017-04-10 04:50:42 UTC) #18
Message was sent while issue was closed.

          

Powered by Google App Engine
This is Rietveld 408576698