android_webview/renderer/aw_print_web_view_helper_delegate.cc - Issue 2508923003: Make printing work better with OOPIF. (try 2)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/renderer/aw_print_web_view_helper_delegate.cc

Issue 2508923003: Make printing work better with OOPIF. (try 2) (Closed)

Patch Set: Fix android_webview Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: android_webview/renderer/aw_print_web_view_helper_delegate.cc

diff --git a/android_webview/renderer/aw_print_web_view_helper_delegate.cc b/android_webview/renderer/aw_print_web_view_helper_delegate.cc

index 517766a8a7c15df7f32f8072ff079cf4c0665ed7..ccb7b2afad1728ff35e7ca71224e5c533e3891ac 100644

--- a/android_webview/renderer/aw_print_web_view_helper_delegate.cc

+++ b/android_webview/renderer/aw_print_web_view_helper_delegate.cc

@@ -8,11 +8,10 @@

namespace android_webview {

-AwPrintWebViewHelperDelegate::~AwPrintWebViewHelperDelegate(){

+AwPrintWebViewHelperDelegate::~AwPrintWebViewHelperDelegate() {}

bool AwPrintWebViewHelperDelegate::CancelPrerender(

- content::RenderView* render_view, int routing_id) {

+ content::RenderFrame* render_frame) {

return false;

}