Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1245)

Unified Diff: chrome/renderer/printing/chrome_print_web_view_helper_delegate.cc

Issue 2508923003: Make printing work better with OOPIF. (try 2) (Closed)
Patch Set: Fix android_webview Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/printing/chrome_print_web_view_helper_delegate.cc
diff --git a/chrome/renderer/printing/chrome_print_web_view_helper_delegate.cc b/chrome/renderer/printing/chrome_print_web_view_helper_delegate.cc
index 0e8b7c5e6368ed2e159db9365a3d94b622981428..0796532247d33d93a1debea4c6d0488fc046c77e 100644
--- a/chrome/renderer/printing/chrome_print_web_view_helper_delegate.cc
+++ b/chrome/renderer/printing/chrome_print_web_view_helper_delegate.cc
@@ -26,17 +26,16 @@
#include "extensions/renderer/guest_view/mime_handler_view/mime_handler_view_container.h"
#endif // BUILDFLAG(ENABLE_EXTENSIONS)
-ChromePrintWebViewHelperDelegate::~ChromePrintWebViewHelperDelegate(){
-}
+ChromePrintWebViewHelperDelegate::~ChromePrintWebViewHelperDelegate() {}
bool ChromePrintWebViewHelperDelegate::CancelPrerender(
- content::RenderView* render_view, int routing_id) {
- if (!render_view || !prerender::PrerenderHelper::IsPrerendering(
- render_view->GetMainRenderFrame()))
+ content::RenderFrame* render_frame) {
+ if (!prerender::PrerenderHelper::IsPrerendering(render_frame))
return false;
- return render_view->Send(
- new ChromeViewHostMsg_CancelPrerenderForPrinting(routing_id));
+ auto* render_view = render_frame->GetRenderView();
+ return render_view->Send(new ChromeViewHostMsg_CancelPrerenderForPrinting(
+ render_view->GetRoutingID()));
}
// Return the PDF object element if |frame| is the out of process PDF extension.
« no previous file with comments | « chrome/renderer/printing/chrome_print_web_view_helper_delegate.h ('k') | components/printing/browser/print_manager.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698