chrome/browser/ui/cocoa/applescript/tab_applescript.mm - Issue 2508923003: Make printing work better with OOPIF. (try 2)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/applescript/tab_applescript.mm

Issue 2508923003: Make printing work better with OOPIF. (try 2) (Closed)

Patch Set: Fix android_webview Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/cocoa/applescript/tab_applescript.mm

diff --git a/chrome/browser/ui/cocoa/applescript/tab_applescript.mm b/chrome/browser/ui/cocoa/applescript/tab_applescript.mm

index ebd35211044e3303bb55f31f05d1bc7b5ba7c44d..cb9d140b167f9cee8dbf41a43e4fea1321a57391 100644

--- a/chrome/browser/ui/cocoa/applescript/tab_applescript.mm

+++ b/chrome/browser/ui/cocoa/applescript/tab_applescript.mm

@@ -231,8 +231,8 @@ void ResumeAppleEventAndSendReply(NSAppleEventManagerSuspensionID suspension_id,

- (void)handlesPrintScriptCommand:(NSScriptCommand*)command {

AppleScript::LogAppleScriptUMA(AppleScript::AppleScriptCommand::TAB_PRINT);

- bool initiated =

- printing::PrintViewManager::FromWebContents(webContents_)->PrintNow();

+ bool initiated = printing::PrintViewManager::FromWebContents(webContents_)

+ ->PrintNow(webContents_->GetMainFrame());

if (!initiated) {

AppleScript::SetError(AppleScript::errInitiatePrinting);

}