chrome/renderer/printing/chrome_print_web_view_helper_delegate.h - Issue 2508923003: Make printing work better with OOPIF. (try 2)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/printing/chrome_print_web_view_helper_delegate.h

Issue 2508923003: Make printing work better with OOPIF. (try 2) (Closed)

Patch Set: Fix android_webview Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/renderer/printing/chrome_print_web_view_helper_delegate.h

diff --git a/chrome/renderer/printing/chrome_print_web_view_helper_delegate.h b/chrome/renderer/printing/chrome_print_web_view_helper_delegate.h

index dae1adea1860216ff4d06733f5018f05fde01080..4e4ef62d794f717be39c0f64bf49f7c85b3c6d98 100644

--- a/chrome/renderer/printing/chrome_print_web_view_helper_delegate.h

+++ b/chrome/renderer/printing/chrome_print_web_view_helper_delegate.h

@@ -12,8 +12,7 @@ class ChromePrintWebViewHelperDelegate

public:

~ChromePrintWebViewHelperDelegate() override;

- bool CancelPrerender(content::RenderView* render_view,

- int routing_id) override;

+ bool CancelPrerender(content::RenderFrame* render_frame) override;

blink::WebElement GetPdfElement(blink::WebLocalFrame* frame) override;