chrome/browser/printing/print_preview_dialog_controller_browsertest.cc - Issue 2508923003: Make printing work better with OOPIF. (try 2)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/printing/print_preview_dialog_controller_browsertest.cc

Issue 2508923003: Make printing work better with OOPIF. (try 2) (Closed)

Patch Set: Fix android_webview Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/printing/print_preview_dialog_controller_browsertest.cc

diff --git a/chrome/browser/printing/print_preview_dialog_controller_browsertest.cc b/chrome/browser/printing/print_preview_dialog_controller_browsertest.cc

index e7dd7eab8b83bc00d264ab2cf3754f6e87c3fe75..598a121a912ac3ce0591566a8938ef2e9e84cc6a 100644

--- a/chrome/browser/printing/print_preview_dialog_controller_browsertest.cc

+++ b/chrome/browser/printing/print_preview_dialog_controller_browsertest.cc

@@ -58,7 +58,8 @@ class RequestPrintPreviewObserver : public WebContentsObserver {

private:

// content::WebContentsObserver implementation.

- bool OnMessageReceived(const IPC::Message& message) override {

+ bool OnMessageReceived(const IPC::Message& message,

+ content::RenderFrameHost* render_frame_host) override {

IPC_BEGIN_MESSAGE_MAP(RequestPrintPreviewObserver, message)

IPC_MESSAGE_HANDLER(PrintHostMsg_RequestPrintPreview,

OnRequestPrintPreview)

« no previous file with comments | « chrome/browser/android/tab_android.cc ('k') | chrome/browser/printing/print_preview_dialog_controller_unittest.cc » ('j') | no next file with comments »