Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issue 2508793002: Make exceptionState parameter of Document::createElement() to have default value (Closed)

Created:
4 years, 1 month ago by yosin_UTC9
Modified:
4 years, 1 month ago
Reviewers:
tkent
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, blink-reviews-dom_chromium.org, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink, dominicc+watchlist_chromium.org, dtapuska+blinkwatch_chromium.org, eae+blinkwatch, Eric Willigers, kinuko+watch, Navid Zolghadr, rjwright, rwlbuis, shans, sof, webcomponents-bugzilla_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make exceptionState parameter of Document::createElement() to have default value This patch makes |exceptionState| parameter of |Document::createElement()| to take |ASSERT_NO_EXCEPTION| as default value for ease of writing unit test. BUG=n/a TEST=n/a; no behavior changes Committed: https://crrev.com/1e54b21a6111572362529f6b72c7d13375380dc9 Cr-Commit-Position: refs/heads/master@{#432418}

Patch Set 1 : 2016-11-16T15:26:06 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -44 lines) Patch
M third_party/WebKit/Source/core/animation/AnimationStackTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/animation/AnimationTest.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/animation/CompositorAnimationsTest.cpp View 2 chunks +2 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/animation/EffectInputTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/animation/KeyframeEffectTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/Document.h View 2 chunks +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/dom/RangeTest.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/dom/ScriptRunnerTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/TreeScopeTest.cpp View 5 chunks +9 lines, -18 lines 0 comments Download
M third_party/WebKit/Source/core/dom/custom/CustomElementTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/EditingUtilitiesTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/FrameSelectionTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/InputMethodControllerTest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/editing/VisiblePositionTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/VisibleUnitsTest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommandTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/forms/OptionListTest.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/input/EventHandlerTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/tests/WebViewTest.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (7 generated)
yosin_UTC9
PTAL
4 years, 1 month ago (2016-11-16 06:44:11 UTC) #5
tkent
lgtm
4 years, 1 month ago (2016-11-16 06:58:02 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2508793002/1
4 years, 1 month ago (2016-11-16 06:59:02 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-16 08:05:37 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-11-16 08:09:58 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1e54b21a6111572362529f6b72c7d13375380dc9
Cr-Commit-Position: refs/heads/master@{#432418}

Powered by Google App Engine
This is Rietveld 408576698