Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Side by Side Diff: third_party/WebKit/Source/core/animation/EffectInputTest.cpp

Issue 2508793002: Make exceptionState parameter of Document::createElement() to have default value (Closed)
Patch Set: 2016-11-16T15:26:06 Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "core/animation/EffectInput.h" 5 #include "core/animation/EffectInput.h"
6 6
7 #include "bindings/core/v8/Dictionary.h" 7 #include "bindings/core/v8/Dictionary.h"
8 #include "bindings/core/v8/DictionarySequenceOrDictionary.h" 8 #include "bindings/core/v8/DictionarySequenceOrDictionary.h"
9 #include "bindings/core/v8/V8BindingForTesting.h" 9 #include "bindings/core/v8/V8BindingForTesting.h"
10 #include "core/animation/AnimationTestHelper.h" 10 #include "core/animation/AnimationTestHelper.h"
11 #include "core/animation/KeyframeEffectModel.h" 11 #include "core/animation/KeyframeEffectModel.h"
12 #include "core/dom/Document.h" 12 #include "core/dom/Document.h"
13 #include "core/dom/Element.h" 13 #include "core/dom/Element.h"
14 #include "core/dom/ExceptionCode.h" 14 #include "core/dom/ExceptionCode.h"
15 #include "core/testing/DummyPageHolder.h" 15 #include "core/testing/DummyPageHolder.h"
16 #include "testing/gtest/include/gtest/gtest.h" 16 #include "testing/gtest/include/gtest/gtest.h"
17 #include <memory> 17 #include <memory>
18 #include <v8.h> 18 #include <v8.h>
19 19
20 namespace blink { 20 namespace blink {
21 21
22 Element* appendElement(Document& document) { 22 Element* appendElement(Document& document) {
23 Element* element = document.createElement("foo", ASSERT_NO_EXCEPTION); 23 Element* element = document.createElement("foo");
24 document.documentElement()->appendChild(element); 24 document.documentElement()->appendChild(element);
25 return element; 25 return element;
26 } 26 }
27 27
28 TEST(AnimationEffectInputTest, SortedOffsets) { 28 TEST(AnimationEffectInputTest, SortedOffsets) {
29 V8TestingScope scope; 29 V8TestingScope scope;
30 Vector<Dictionary> jsKeyframes; 30 Vector<Dictionary> jsKeyframes;
31 v8::Local<v8::Object> keyframe1 = v8::Object::New(scope.isolate()); 31 v8::Local<v8::Object> keyframe1 = v8::Object::New(scope.isolate());
32 v8::Local<v8::Object> keyframe2 = v8::Object::New(scope.isolate()); 32 v8::Local<v8::Object> keyframe2 = v8::Object::New(scope.isolate());
33 33
(...skipping 131 matching lines...) Expand 10 before | Expand all | Expand 10 after
165 Element* element = appendElement(scope.document()); 165 Element* element = appendElement(scope.document());
166 EffectInput::convert( 166 EffectInput::convert(
167 element, 167 element,
168 DictionarySequenceOrDictionary::fromDictionarySequence(jsKeyframes), 168 DictionarySequenceOrDictionary::fromDictionarySequence(jsKeyframes),
169 nullptr, scope.getExceptionState()); 169 nullptr, scope.getExceptionState());
170 EXPECT_TRUE(scope.getExceptionState().hadException()); 170 EXPECT_TRUE(scope.getExceptionState().hadException());
171 EXPECT_EQ(V8TypeError, scope.getExceptionState().code()); 171 EXPECT_EQ(V8TypeError, scope.getExceptionState().code());
172 } 172 }
173 173
174 } // namespace blink 174 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698