third_party/WebKit/Source/core/editing/VisiblePositionTest.cpp - Issue 2508793002: Make exceptionState parameter of Document::createElement() to have default value

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/VisiblePositionTest.cpp

Issue 2508793002: Make exceptionState parameter of Document::createElement() to have default value (Closed)

Patch Set: 2016-11-16T15:26:06 Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/editing/VisiblePositionTest.cpp

diff --git a/third_party/WebKit/Source/core/editing/VisiblePositionTest.cpp b/third_party/WebKit/Source/core/editing/VisiblePositionTest.cpp

index bb5f46cb97c0b2f3b15df9fd93ea117566b5f072..84464d11f15431bec476dca7f8fa2fcdc74d0890 100644

--- a/third_party/WebKit/Source/core/editing/VisiblePositionTest.cpp

+++ b/third_party/WebKit/Source/core/editing/VisiblePositionTest.cpp

@@ -69,7 +69,7 @@ TEST_F(VisiblePositionTest, NonNullInvalidatedAfterDOMChange) {

VisiblePosition nullVisiblePosition;

VisiblePosition nonNullVisiblePosition = createVisiblePosition(position);

- Element* div = document().createElement("div", ASSERT_NO_EXCEPTION);

+ Element* div = document().createElement("div");

document().body()->appendChild(div);

EXPECT_TRUE(nullVisiblePosition.isValid());