third_party/WebKit/Source/core/editing/FrameSelectionTest.cpp - Issue 2508793002: Make exceptionState parameter of Document::createElement() to have default value

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/FrameSelectionTest.cpp

Issue 2508793002: Make exceptionState parameter of Document::createElement() to have default value (Closed)

Patch Set: 2016-11-16T15:26:06 Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/editing/FrameSelectionTest.cpp

diff --git a/third_party/WebKit/Source/core/editing/FrameSelectionTest.cpp b/third_party/WebKit/Source/core/editing/FrameSelectionTest.cpp

index 6bfbf0e91e971504f87cea52faaeac2f5e5cd830..957867fc4929fde2c45f5ab09514d3d11b16d886 100644

--- a/third_party/WebKit/Source/core/editing/FrameSelectionTest.cpp

+++ b/third_party/WebKit/Source/core/editing/FrameSelectionTest.cpp

@@ -296,7 +296,7 @@ class SelectionControllerTest : public EditingTestBase {

};

TEST_F(FrameSelectionTest, SelectAllWithUnselectableRoot) {

- Element* select = document().createElement("select", ASSERT_NO_EXCEPTION);

+ Element* select = document().createElement("select");

document().replaceChild(select, document().documentElement());

selection().selectAll();

EXPECT_TRUE(selection().isNone()) << "Nothing should be selected if the "