Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Unified Diff: third_party/WebKit/Source/core/dom/TreeScopeTest.cpp

Issue 2508793002: Make exceptionState parameter of Document::createElement() to have default value (Closed)
Patch Set: 2016-11-16T15:26:06 Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/dom/TreeScopeTest.cpp
diff --git a/third_party/WebKit/Source/core/dom/TreeScopeTest.cpp b/third_party/WebKit/Source/core/dom/TreeScopeTest.cpp
index a5f1335f8666711ab11418cb594d6f468803c4d1..90053b2db42a7b79aa04183ec7d82a1ca0dc92aa 100644
--- a/third_party/WebKit/Source/core/dom/TreeScopeTest.cpp
+++ b/third_party/WebKit/Source/core/dom/TreeScopeTest.cpp
@@ -16,8 +16,7 @@ TEST(TreeScopeTest, CommonAncestorOfSameTrees) {
Document* document = Document::create();
EXPECT_EQ(document, document->commonAncestorTreeScope(*document));
- Element* html = document->createElement("html", StringOrDictionary(),
- ASSERT_NO_EXCEPTION);
+ Element* html = document->createElement("html", StringOrDictionary());
document->appendChild(html, ASSERT_NO_EXCEPTION);
ShadowRoot* shadowRoot =
html->createShadowRootInternal(ShadowRootType::V0, ASSERT_NO_EXCEPTION);
@@ -30,8 +29,7 @@ TEST(TreeScopeTest, CommonAncestorOfInclusiveTrees) {
// shadowRoot
Document* document = Document::create();
- Element* html = document->createElement("html", StringOrDictionary(),
- ASSERT_NO_EXCEPTION);
+ Element* html = document->createElement("html", StringOrDictionary());
document->appendChild(html, ASSERT_NO_EXCEPTION);
ShadowRoot* shadowRoot =
html->createShadowRootInternal(ShadowRootType::V0, ASSERT_NO_EXCEPTION);
@@ -46,14 +44,11 @@ TEST(TreeScopeTest, CommonAncestorOfSiblingTrees) {
// A B
Document* document = Document::create();
- Element* html = document->createElement("html", StringOrDictionary(),
- ASSERT_NO_EXCEPTION);
+ Element* html = document->createElement("html", StringOrDictionary());
document->appendChild(html, ASSERT_NO_EXCEPTION);
- Element* head = document->createElement("head", StringOrDictionary(),
- ASSERT_NO_EXCEPTION);
+ Element* head = document->createElement("head", StringOrDictionary());
html->appendChild(head);
- Element* body = document->createElement("body", StringOrDictionary(),
- ASSERT_NO_EXCEPTION);
+ Element* body = document->createElement("body", StringOrDictionary());
html->appendChild(body);
ShadowRoot* shadowRootA =
@@ -73,14 +68,11 @@ TEST(TreeScopeTest, CommonAncestorOfTreesAtDifferentDepths) {
// A
Document* document = Document::create();
- Element* html = document->createElement("html", StringOrDictionary(),
- ASSERT_NO_EXCEPTION);
+ Element* html = document->createElement("html", StringOrDictionary());
document->appendChild(html, ASSERT_NO_EXCEPTION);
- Element* head = document->createElement("head", StringOrDictionary(),
- ASSERT_NO_EXCEPTION);
+ Element* head = document->createElement("head", StringOrDictionary());
html->appendChild(head);
- Element* body = document->createElement("body", StringOrDictionary(),
- ASSERT_NO_EXCEPTION);
+ Element* body = document->createElement("body", StringOrDictionary());
html->appendChild(body);
ShadowRoot* shadowRootY =
@@ -88,8 +80,7 @@ TEST(TreeScopeTest, CommonAncestorOfTreesAtDifferentDepths) {
ShadowRoot* shadowRootB =
body->createShadowRootInternal(ShadowRootType::V0, ASSERT_NO_EXCEPTION);
- Element* divInY =
- document->createElement("div", StringOrDictionary(), ASSERT_NO_EXCEPTION);
+ Element* divInY = document->createElement("div", StringOrDictionary());
shadowRootY->appendChild(divInY);
ShadowRoot* shadowRootA =
divInY->createShadowRootInternal(ShadowRootType::V0, ASSERT_NO_EXCEPTION);

Powered by Google App Engine
This is Rietveld 408576698