Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(310)

Side by Side Diff: third_party/WebKit/Source/core/editing/VisiblePositionTest.cpp

Issue 2508793002: Make exceptionState parameter of Document::createElement() to have default value (Closed)
Patch Set: 2016-11-16T15:26:06 Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "core/editing/VisiblePosition.h" 5 #include "core/editing/VisiblePosition.h"
6 6
7 #include "core/css/CSSStyleDeclaration.h" 7 #include "core/css/CSSStyleDeclaration.h"
8 #include "core/editing/EditingTestBase.h" 8 #include "core/editing/EditingTestBase.h"
9 #include "core/editing/VisibleUnits.h" 9 #include "core/editing/VisibleUnits.h"
10 10
(...skipping 51 matching lines...) Expand 10 before | Expand all | Expand 10 after
62 } 62 }
63 63
64 TEST_F(VisiblePositionTest, NonNullInvalidatedAfterDOMChange) { 64 TEST_F(VisiblePositionTest, NonNullInvalidatedAfterDOMChange) {
65 setBodyContent("<p>one</p>"); 65 setBodyContent("<p>one</p>");
66 66
67 Element* paragraph = document().querySelector("p"); 67 Element* paragraph = document().querySelector("p");
68 Position position(paragraph->firstChild(), 1); 68 Position position(paragraph->firstChild(), 1);
69 VisiblePosition nullVisiblePosition; 69 VisiblePosition nullVisiblePosition;
70 VisiblePosition nonNullVisiblePosition = createVisiblePosition(position); 70 VisiblePosition nonNullVisiblePosition = createVisiblePosition(position);
71 71
72 Element* div = document().createElement("div", ASSERT_NO_EXCEPTION); 72 Element* div = document().createElement("div");
73 document().body()->appendChild(div); 73 document().body()->appendChild(div);
74 74
75 EXPECT_TRUE(nullVisiblePosition.isValid()); 75 EXPECT_TRUE(nullVisiblePosition.isValid());
76 EXPECT_FALSE(nonNullVisiblePosition.isValid()); 76 EXPECT_FALSE(nonNullVisiblePosition.isValid());
77 77
78 updateAllLifecyclePhases(); 78 updateAllLifecyclePhases();
79 79
80 // Invalid VisiblePosition can never become valid again. 80 // Invalid VisiblePosition can never become valid again.
81 EXPECT_FALSE(nonNullVisiblePosition.isValid()); 81 EXPECT_FALSE(nonNullVisiblePosition.isValid());
82 } 82 }
(...skipping 19 matching lines...) Expand all
102 updateAllLifecyclePhases(); 102 updateAllLifecyclePhases();
103 103
104 // Invalid VisiblePosition can never become valid again. 104 // Invalid VisiblePosition can never become valid again.
105 EXPECT_FALSE(visiblePosition1.isValid()); 105 EXPECT_FALSE(visiblePosition1.isValid());
106 EXPECT_FALSE(visiblePosition2.isValid()); 106 EXPECT_FALSE(visiblePosition2.isValid());
107 } 107 }
108 108
109 #endif 109 #endif
110 110
111 } // namespace blink 111 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698