net: move udp directory into socket

net: move udp directory into socket

After discussing with OWNERS we agreed that net/udp is inconsistent and
lonely.

Today socket/ is a dumping ground for both interface and most implementations
(sockets + socket pools X, tcp, ssl, socks, unix domain, websocket), so since
even TCP is there it seems to make more sense to have UDP there as well.

BUG=None
R=eroman@chromium.org,rch@chromium.org
TBR=thestig@chromium.org,avi@chromium.org,asargent@chromium.org,hubbe@chromium.org

Committed: https://crrev.com/5dd13c29673c2a34b82caf82e0b00345680bceda
Cr-Commit-Position: refs/heads/master@{#432463}

[tfarina, 2016-11-15 23:23:58]

The CQ bit was checked by tfarina@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-15 23:24:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[eroman, 2016-11-15 23:41:45]

patchset1 lgtm

https://codereview.chromium.org/2508593002/diff/1/net/dns/address_sorter_posi...
File net/dns/address_sorter_posix.cc (right):

https://codereview.chromium.org/2508593002/diff/1/net/dns/address_sorter_posi...
net/dns/address_sorter_posix.cc:18: #include <sys/socket.h>  // Must be included
before ifaddrs.h.
The comment suggests this shouldn't be moved.

https://codereview.chromium.org/2508593002/diff/1/net/net.gypi
File net/net.gypi (right):

https://codereview.chromium.org/2508593002/diff/1/net/net.gypi#newcode893
net/net.gypi:893: 'quic/chromium/quic_http_stream.cc',
These are good changes, however in the future I would rather see re-ordering
refactors as a separate review.

[tfarina, 2016-11-15 23:48:25]

https://codereview.chromium.org/2508593002/diff/1/net/net.gypi
File net/net.gypi (right):

https://codereview.chromium.org/2508593002/diff/1/net/net.gypi#newcode893
net/net.gypi:893: 'quic/chromium/quic_http_stream.cc',
On 2016/11/15 23:41:45, eroman (slow) wrote:
> These are good changes, however in the future I would rather see re-ordering
> refactors as a separate review.

I definetly agree with you. Perhaps move_source_file.py should learn not to
reoder the other entries it is not moving.

https://chromium.googlesource.com/chromium/src/+/a628a42300fb022c51210395e2cf...

[commit-bot: I haz the power, 2016-11-15 23:50:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-15 23:50:30]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[tfarina, 2016-11-15 23:59:03]

The CQ bit was checked by tfarina@chromium.org to run a CQ dry run

[tfarina, 2016-11-15 23:59:13]

https://codereview.chromium.org/2508593002/diff/1/net/dns/address_sorter_posi...
File net/dns/address_sorter_posix.cc (right):

https://codereview.chromium.org/2508593002/diff/1/net/dns/address_sorter_posi...
net/dns/address_sorter_posix.cc:18: #include <sys/socket.h>  // Must be included
before ifaddrs.h.
On 2016/11/15 23:41:45, eroman (slow) wrote:
> The comment suggests this shouldn't be moved.

No idea how that ended up here. I didn't run sort-headers.py on it. :/

[commit-bot: I haz the power, 2016-11-15 23:59:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[eroman, 2016-11-16 00:06:42]

patchset2 lgtm

[commit-bot: I haz the power, 2016-11-16 01:46:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-16 01:46:49]

Dry run: This issue passed the CQ dry run.

[Ryan Hamilton, 2016-11-16 02:58:24]

rch@chromium.org changed reviewers:
+ rch@chromium.org

[Ryan Hamilton, 2016-11-16 02:58:25]

LGTM!

[tfarina, 2016-11-16 11:59:40]

tfarina@chromium.org changed reviewers:
+ asargent@chromium.org, avi@chromium.org, hubbe@chromium.org,
thestig@chromium.org

[tfarina, 2016-11-16 11:59:40]

TBR the owners for the trivial changes outside net.

Lei -> chrome
Avi -> content
Antony -> extensions
Hubbe -> media

[tfarina, 2016-11-16 12:00:44]

Description was changed from

==========
net: move udp directory into socket

After discussing with OWNERS we agreed that net/udp is inconsistent and
lonely.

Today socket/ is a dumping ground for both interface and most implementations
(sockets + socket pools X, tcp, ssl, socks, unix domain, websocket), so since
even TCP is there it seems to make more sense to have UDP there as well.

BUG=None
R=eroman@chromium.org
==========

to

==========
net: move udp directory into socket

After discussing with OWNERS we agreed that net/udp is inconsistent and
lonely.

Today socket/ is a dumping ground for both interface and most implementations
(sockets + socket pools X, tcp, ssl, socks, unix domain, websocket), so since
even TCP is there it seems to make more sense to have UDP there as well.

BUG=None
R=eroman@chromium.org,rch@chromium.org
TBR=thestig@chromium.org,avi@chromium.org,asargent@chromium.org,hubbe@chromiu...
==========

[tfarina, 2016-11-16 12:00:54]

The CQ bit was checked by tfarina@chromium.org

[commit-bot: I haz the power, 2016-11-16 12:01:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-16 12:08:58]

Description was changed from

==========
net: move udp directory into socket

After discussing with OWNERS we agreed that net/udp is inconsistent and
lonely.

Today socket/ is a dumping ground for both interface and most implementations
(sockets + socket pools X, tcp, ssl, socks, unix domain, websocket), so since
even TCP is there it seems to make more sense to have UDP there as well.

BUG=None
R=eroman@chromium.org,rch@chromium.org
TBR=thestig@chromium.org,avi@chromium.org,asargent@chromium.org,hubbe@chromiu...
==========

to

==========
net: move udp directory into socket

After discussing with OWNERS we agreed that net/udp is inconsistent and
lonely.

Today socket/ is a dumping ground for both interface and most implementations
(sockets + socket pools X, tcp, ssl, socks, unix domain, websocket), so since
even TCP is there it seems to make more sense to have UDP there as well.

BUG=None
R=eroman@chromium.org,rch@chromium.org
TBR=thestig@chromium.org,avi@chromium.org,asargent@chromium.org,hubbe@chromiu...
==========

[commit-bot: I haz the power, 2016-11-16 12:08:59]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-16 12:11:17]

Description was changed from

==========
net: move udp directory into socket

After discussing with OWNERS we agreed that net/udp is inconsistent and
lonely.

Today socket/ is a dumping ground for both interface and most implementations
(sockets + socket pools X, tcp, ssl, socks, unix domain, websocket), so since
even TCP is there it seems to make more sense to have UDP there as well.

BUG=None
R=eroman@chromium.org,rch@chromium.org
TBR=thestig@chromium.org,avi@chromium.org,asargent@chromium.org,hubbe@chromiu...
==========

to

==========
net: move udp directory into socket

After discussing with OWNERS we agreed that net/udp is inconsistent and
lonely.

Today socket/ is a dumping ground for both interface and most implementations
(sockets + socket pools X, tcp, ssl, socks, unix domain, websocket), so since
even TCP is there it seems to make more sense to have UDP there as well.

BUG=None
R=eroman@chromium.org,rch@chromium.org
TBR=thestig@chromium.org,avi@chromium.org,asargent@chromium.org,hubbe@chromiu...

Committed: https://crrev.com/5dd13c29673c2a34b82caf82e0b00345680bceda
Cr-Commit-Position: refs/heads/master@{#432463}
==========

[commit-bot: I haz the power, 2016-11-16 12:11:18]

Patchset 2 (id:??) landed as
https://crrev.com/5dd13c29673c2a34b82caf82e0b00345680bceda
Cr-Commit-Position: refs/heads/master@{#432463}

[Avi (use Gerrit), 2016-11-16 15:27:15]

lgtm

stamp

[hubbe, 2016-11-16 18:11:40]

media LGTM

[Lei Zhang, 2016-11-16 21:02:58]

lgtm