Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 2504583003: Fix QuadF::ContainsPoint and gfx::CrossProduct on arm64 (Closed)

Created:
4 years, 1 month ago by danakj
Modified:
4 years, 1 month ago
Reviewers:
Nico, enne (OOO)
CC:
cc-bugs_chromium.org, chromium-reviews, Nico
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix QuadF::ContainsPoint and gfx::CrossProduct on arm64 These methods require the use of doubles to not give incorrect answers. Tests were failing on arm64 due to precision mistakes with floats. BUG=662561, 662556 Committed: https://crrev.com/1f740dbd1a15d3a904f40a4175eaad8c536becd7 Cr-Commit-Position: refs/heads/master@{#432685}

Patch Set 1 #

Patch Set 2 : quadtest: . #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -17 lines) Patch
M ui/gfx/geometry/quad_f.cc View 1 1 chunk +11 lines, -4 lines 0 comments Download
M ui/gfx/geometry/quad_unittest.cc View 1 1 chunk +0 lines, -3 lines 0 comments Download
M ui/gfx/geometry/vector3d_f.cc View 1 1 chunk +6 lines, -3 lines 0 comments Download
M ui/gfx/geometry/vector3d_unittest.cc View 1 2 chunks +2 lines, -7 lines 2 comments Download

Messages

Total messages: 22 (15 generated)
danakj
4 years, 1 month ago (2016-11-16 22:28:44 UTC) #6
Nico
lgtm, thanks! https://codereview.chromium.org/2504583003/diff/20001/ui/gfx/geometry/vector3d_unittest.cc File ui/gfx/geometry/vector3d_unittest.cc (right): https://codereview.chromium.org/2504583003/diff/20001/ui/gfx/geometry/vector3d_unittest.cc#newcode230 ui/gfx/geometry/vector3d_unittest.cc:230: SCOPED_TRACE(i); remove?
4 years, 1 month ago (2016-11-16 22:36:16 UTC) #11
danakj
https://codereview.chromium.org/2504583003/diff/20001/ui/gfx/geometry/vector3d_unittest.cc File ui/gfx/geometry/vector3d_unittest.cc (right): https://codereview.chromium.org/2504583003/diff/20001/ui/gfx/geometry/vector3d_unittest.cc#newcode230 ui/gfx/geometry/vector3d_unittest.cc:230: SCOPED_TRACE(i); On 2016/11/16 22:36:15, Nico (ooo sick Nov 16) ...
4 years, 1 month ago (2016-11-16 22:36:48 UTC) #12
enne (OOO)
lgtm
4 years, 1 month ago (2016-11-16 22:38:39 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2504583003/20001
4 years, 1 month ago (2016-11-16 23:52:21 UTC) #18
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-17 01:42:42 UTC) #20
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 01:48:26 UTC) #22
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/1f740dbd1a15d3a904f40a4175eaad8c536becd7
Cr-Commit-Position: refs/heads/master@{#432685}

Powered by Google App Engine
This is Rietveld 408576698