Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(499)

Side by Side Diff: ui/gfx/geometry/quad_unittest.cc

Issue 2504583003: Fix QuadF::ContainsPoint and gfx::CrossProduct on arm64 (Closed)
Patch Set: quadtest: . Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <stddef.h> 5 #include <stddef.h>
6 6
7 #include "base/macros.h" 7 #include "base/macros.h"
8 #include "build/build_config.h" 8 #include "build/build_config.h"
9 #include "testing/gtest/include/gtest/gtest.h" 9 #include "testing/gtest/include/gtest/gtest.h"
10 #include "ui/gfx/geometry/quad_f.h" 10 #include "ui/gfx/geometry/quad_f.h"
(...skipping 265 matching lines...) Expand 10 before | Expand all | Expand 10 after
276 EXPECT_FALSE(QuadF(a, b, c, d).Contains(b - bd_center)); 276 EXPECT_FALSE(QuadF(a, b, c, d).Contains(b - bd_center));
277 EXPECT_FALSE(QuadF(a, b, c, d).Contains(c + ac_center)); 277 EXPECT_FALSE(QuadF(a, b, c, d).Contains(c + ac_center));
278 EXPECT_FALSE(QuadF(a, b, c, d).Contains(d + bd_center)); 278 EXPECT_FALSE(QuadF(a, b, c, d).Contains(d + bd_center));
279 279
280 EXPECT_TRUE(QuadF(a, b, c, d).Contains(a)); 280 EXPECT_TRUE(QuadF(a, b, c, d).Contains(a));
281 EXPECT_FALSE(QuadF(a, b, c, d).Contains(a - epsilon_x)); 281 EXPECT_FALSE(QuadF(a, b, c, d).Contains(a - epsilon_x));
282 EXPECT_FALSE(QuadF(a, b, c, d).Contains(a - epsilon_y)); 282 EXPECT_FALSE(QuadF(a, b, c, d).Contains(a - epsilon_y));
283 EXPECT_FALSE(QuadF(a, b, c, d).Contains(a + epsilon_x)); 283 EXPECT_FALSE(QuadF(a, b, c, d).Contains(a + epsilon_x));
284 EXPECT_TRUE(QuadF(a, b, c, d).Contains(a + epsilon_y)); 284 EXPECT_TRUE(QuadF(a, b, c, d).Contains(a + epsilon_y));
285 285
286 #if !defined(ARCH_CPU_ARM_FAMILY)
287 // TODO(danakj): Make this pass on ARM, https://crbug.com/662561
288 EXPECT_TRUE(QuadF(a, b, c, d).Contains(b)); 286 EXPECT_TRUE(QuadF(a, b, c, d).Contains(b));
289 #endif
290 EXPECT_FALSE(QuadF(a, b, c, d).Contains(b - epsilon_x)); 287 EXPECT_FALSE(QuadF(a, b, c, d).Contains(b - epsilon_x));
291 EXPECT_FALSE(QuadF(a, b, c, d).Contains(b - epsilon_y)); 288 EXPECT_FALSE(QuadF(a, b, c, d).Contains(b - epsilon_y));
292 EXPECT_TRUE(QuadF(a, b, c, d).Contains(b + epsilon_x)); 289 EXPECT_TRUE(QuadF(a, b, c, d).Contains(b + epsilon_x));
293 EXPECT_FALSE(QuadF(a, b, c, d).Contains(b + epsilon_y)); 290 EXPECT_FALSE(QuadF(a, b, c, d).Contains(b + epsilon_y));
294 291
295 EXPECT_TRUE(QuadF(a, b, c, d).Contains(c)); 292 EXPECT_TRUE(QuadF(a, b, c, d).Contains(c));
296 EXPECT_FALSE(QuadF(a, b, c, d).Contains(c - epsilon_x)); 293 EXPECT_FALSE(QuadF(a, b, c, d).Contains(c - epsilon_x));
297 EXPECT_TRUE(QuadF(a, b, c, d).Contains(c - epsilon_y)); 294 EXPECT_TRUE(QuadF(a, b, c, d).Contains(c - epsilon_y));
298 EXPECT_FALSE(QuadF(a, b, c, d).Contains(c + epsilon_x)); 295 EXPECT_FALSE(QuadF(a, b, c, d).Contains(c + epsilon_x));
299 EXPECT_FALSE(QuadF(a, b, c, d).Contains(c + epsilon_y)); 296 EXPECT_FALSE(QuadF(a, b, c, d).Contains(c + epsilon_y));
(...skipping 55 matching lines...) Expand 10 before | Expand all | Expand 10 after
355 PointF c_scaled = ScalePoint(c, 1.5f); 352 PointF c_scaled = ScalePoint(c, 1.5f);
356 PointF d_scaled = ScalePoint(d, 1.5f); 353 PointF d_scaled = ScalePoint(d, 1.5f);
357 EXPECT_EQ(q1, QuadF(a_scaled, b_scaled, c_scaled, d_scaled)); 354 EXPECT_EQ(q1, QuadF(a_scaled, b_scaled, c_scaled, d_scaled));
358 355
359 QuadF q2; 356 QuadF q2;
360 q2.Scale(1.5f); 357 q2.Scale(1.5f);
361 EXPECT_EQ(q2, q2); 358 EXPECT_EQ(q2, q2);
362 } 359 }
363 360
364 } // namespace gfx 361 } // namespace gfx
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698