Fix QuadF::ContainsPoint and gfx::CrossProduct on arm64

ui/gfx/geometry/vector3d_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <stddef.h>
 
 #include <cmath>
 #include <limits>
 
 #include "base/macros.h"
@@ skipping 186 matching lines @@
     { 38.72f,
       gfx::Vector3dF(1.1f, 2.2f, 3.3f), gfx::Vector3dF(4.4f, 5.5f, 6.6f) }
   };
 
   for (size_t i = 0; i < arraysize(tests); ++i) {
     float actual = gfx::DotProduct(tests[i].input1, tests[i].input2);
     EXPECT_EQ(tests[i].expected, actual);
   }
 }
 
-#if defined(ARCH_CPU_ARM_FAMILY)
-// TODO(danakj): Make this pass on ARM, https://crbug.com/662556
-#define MAYBE_CrossProduct DISABLED_CrossProduct
-#else
-#define MAYBE_CrossProduct CrossProduct
-#endif
-TEST(Vector3dTest, MAYBE_CrossProduct) {
+TEST(Vector3dTest, CrossProduct) {
   const struct {
     gfx::Vector3dF expected;
     gfx::Vector3dF input1;
     gfx::Vector3dF input2;
   } tests[] = {
     { Vector3dF(), Vector3dF(), Vector3dF(1, 1, 1) },
     { Vector3dF(), Vector3dF(1, 1, 1), Vector3dF() },
     { Vector3dF(), Vector3dF(1, 1, 1), Vector3dF(1, 1, 1) },
     { Vector3dF(),
       Vector3dF(1.6f, 10.6f, -10.6f),
       Vector3dF(1.6f, 10.6f, -10.6f) },
 
     { Vector3dF(1, -1, 0), Vector3dF(1, 1, 1), Vector3dF(0, 0, 1) },
     { Vector3dF(-1, 0, 1), Vector3dF(1, 1, 1), Vector3dF(0, 1, 0) },
     { Vector3dF(0, 1, -1), Vector3dF(1, 1, 1), Vector3dF(1, 0, 0) },
 
     { Vector3dF(-1, 1, 0), Vector3dF(0, 0, 1), Vector3dF(1, 1, 1) },
     { Vector3dF(1, 0, -1), Vector3dF(0, 1, 0), Vector3dF(1, 1, 1) },
     { Vector3dF(0, -1, 1), Vector3dF(1, 0, 0), Vector3dF(1, 1, 1) }
   };
 
   for (size_t i = 0; i < arraysize(tests); ++i) {
+    SCOPED_TRACE(i);

[Nico, 2016/11/16 22:36:15]

remove?

[danakj, 2016/11/16 22:36:48]

No, I think this should be here. It will report if a failure happened on which
case it happened.

     Vector3dF actual = gfx::CrossProduct(tests[i].input1, tests[i].input2);
     EXPECT_EQ(tests[i].expected.ToString(), actual.ToString());
   }
 }
 
 TEST(Vector3dFTest, ClampVector3dF) {
   Vector3dF a;
 
   a = Vector3dF(3.5f, 5.5f, 7.5f);
   EXPECT_EQ(Vector3dF(3.5f, 5.5f, 7.5f).ToString(), a.ToString());
@@ skipping 71 matching lines @@
     EXPECT_FLOAT_EQ(tests[i].expected, actual);
     actual = -gfx::ClockwiseAngleBetweenVectorsInDegrees(
                  tests[i].input2, tests[i].input1, normal_vector);
     if (actual < 0.0f)
       actual += 360.0f;
     EXPECT_FLOAT_EQ(tests[i].expected, actual);
   }
 }
 
 }  // namespace gfx