Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1354)

Unified Diff: ui/gfx/geometry/vector3d_unittest.cc

Issue 2504583003: Fix QuadF::ContainsPoint and gfx::CrossProduct on arm64 (Closed)
Patch Set: quadtest: . Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/gfx/geometry/vector3d_f.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/gfx/geometry/vector3d_unittest.cc
diff --git a/ui/gfx/geometry/vector3d_unittest.cc b/ui/gfx/geometry/vector3d_unittest.cc
index c2cc99edd614c3b67aeb2d1a71137788e9ebcb77..1aaebb6a4de13318a6afdb2a9606bb586e48ead7 100644
--- a/ui/gfx/geometry/vector3d_unittest.cc
+++ b/ui/gfx/geometry/vector3d_unittest.cc
@@ -204,13 +204,7 @@ TEST(Vector3dTest, DotProduct) {
}
}
-#if defined(ARCH_CPU_ARM_FAMILY)
-// TODO(danakj): Make this pass on ARM, https://crbug.com/662556
-#define MAYBE_CrossProduct DISABLED_CrossProduct
-#else
-#define MAYBE_CrossProduct CrossProduct
-#endif
-TEST(Vector3dTest, MAYBE_CrossProduct) {
+TEST(Vector3dTest, CrossProduct) {
const struct {
gfx::Vector3dF expected;
gfx::Vector3dF input1;
@@ -233,6 +227,7 @@ TEST(Vector3dTest, MAYBE_CrossProduct) {
};
for (size_t i = 0; i < arraysize(tests); ++i) {
+ SCOPED_TRACE(i);
Nico 2016/11/16 22:36:15 remove?
danakj 2016/11/16 22:36:48 No, I think this should be here. It will report if
Vector3dF actual = gfx::CrossProduct(tests[i].input1, tests[i].input2);
EXPECT_EQ(tests[i].expected.ToString(), actual.ToString());
}
« no previous file with comments | « ui/gfx/geometry/vector3d_f.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698