Chromium Code Reviews| Index: ui/gfx/geometry/vector3d_unittest.cc |
| diff --git a/ui/gfx/geometry/vector3d_unittest.cc b/ui/gfx/geometry/vector3d_unittest.cc |
| index c2cc99edd614c3b67aeb2d1a71137788e9ebcb77..1aaebb6a4de13318a6afdb2a9606bb586e48ead7 100644 |
| --- a/ui/gfx/geometry/vector3d_unittest.cc |
| +++ b/ui/gfx/geometry/vector3d_unittest.cc |
| @@ -204,13 +204,7 @@ TEST(Vector3dTest, DotProduct) { |
| } |
| } |
| -#if defined(ARCH_CPU_ARM_FAMILY) |
| -// TODO(danakj): Make this pass on ARM, https://crbug.com/662556 |
| -#define MAYBE_CrossProduct DISABLED_CrossProduct |
| -#else |
| -#define MAYBE_CrossProduct CrossProduct |
| -#endif |
| -TEST(Vector3dTest, MAYBE_CrossProduct) { |
| +TEST(Vector3dTest, CrossProduct) { |
| const struct { |
| gfx::Vector3dF expected; |
| gfx::Vector3dF input1; |
| @@ -233,6 +227,7 @@ TEST(Vector3dTest, MAYBE_CrossProduct) { |
| }; |
| for (size_t i = 0; i < arraysize(tests); ++i) { |
| + SCOPED_TRACE(i); |
|
Nico
2016/11/16 22:36:15
remove?
danakj
2016/11/16 22:36:48
No, I think this should be here. It will report if
|
| Vector3dF actual = gfx::CrossProduct(tests[i].input1, tests[i].input2); |
| EXPECT_EQ(tests[i].expected.ToString(), actual.ToString()); |
| } |