Fix QuadF::ContainsPoint and gfx::CrossProduct on arm64

ui/gfx/geometry/quad_f.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/gfx/geometry/quad_f.h"
 
 #include <limits>
 
 #include "base/strings/stringprintf.h"
 
@@ skipping 58 matching lines @@
   // Compute the barycentric coordinates (u, v, w) of |point| relative to the
   // triangle (r1, r2, r3) by the solving the system of equations:
   //   1) point = u * r1 + v * r2 + w * r3
   //   2) u + v + w = 1
   // This algorithm comes from Christer Ericson's Real-Time Collision Detection.
 
   Vector2dF r31 = r1 - r3;
   Vector2dF r32 = r2 - r3;
   Vector2dF r3p = point - r3;
 
-  float denom = r32.y() * r31.x() - r32.x() * r31.y();
-  float u = (r32.y() * r3p.x() - r32.x() * r3p.y()) / denom;
-  float v = (r31.x() * r3p.y() - r31.y() * r3p.x()) / denom;
-  float w = 1.f - u - v;
+  // Promote to doubles so all the math below is done with doubles, because
+  // otherwise it gets incorrect results on arm64.
+  double r31x = r31.x();
+  double r31y = r31.y();
+  double r32x = r32.x();
+  double r32y = r32.y();
+
+  double denom = r32y * r31x - r32x * r31y;
+  double u = (r32y * r3p.x() - r32x * r3p.y()) / denom;
+  double v = (r31x * r3p.y() - r31y * r3p.x()) / denom;
+  double w = 1.0 - u - v;
 
   // Use the barycentric coordinates to test if |point| is inside the
   // triangle (r1, r2, r2).
   return (u >= 0) && (v >= 0) && (w >= 0);
 }
 
 bool QuadF::Contains(const PointF& point) const {
   return PointIsInTriangle(point, p1_, p2_, p3_)
       || PointIsInTriangle(point, p1_, p3_, p4_);
 }
@@ skipping 25 matching lines @@
   return result;
 }
 
 QuadF operator-(const QuadF& lhs, const Vector2dF& rhs) {
   QuadF result = lhs;
   result -= rhs;
   return result;
 }
 
 }  // namespace gfx