Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Unified Diff: ui/gfx/geometry/quad_unittest.cc

Issue 2504583003: Fix QuadF::ContainsPoint and gfx::CrossProduct on arm64 (Closed)
Patch Set: quadtest: . Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/gfx/geometry/quad_unittest.cc
diff --git a/ui/gfx/geometry/quad_unittest.cc b/ui/gfx/geometry/quad_unittest.cc
index 26b3bf9fb48c322722f41d11ed18df457071bd23..2731583aab8effb03706473f09a9f26f1a2adaa6 100644
--- a/ui/gfx/geometry/quad_unittest.cc
+++ b/ui/gfx/geometry/quad_unittest.cc
@@ -283,10 +283,7 @@ TEST(QuadTest, ContainsPoint) {
EXPECT_FALSE(QuadF(a, b, c, d).Contains(a + epsilon_x));
EXPECT_TRUE(QuadF(a, b, c, d).Contains(a + epsilon_y));
-#if !defined(ARCH_CPU_ARM_FAMILY)
- // TODO(danakj): Make this pass on ARM, https://crbug.com/662561
EXPECT_TRUE(QuadF(a, b, c, d).Contains(b));
-#endif
EXPECT_FALSE(QuadF(a, b, c, d).Contains(b - epsilon_x));
EXPECT_FALSE(QuadF(a, b, c, d).Contains(b - epsilon_y));
EXPECT_TRUE(QuadF(a, b, c, d).Contains(b + epsilon_x));

Powered by Google App Engine
This is Rietveld 408576698