Changes alerts page buttons to reflect state of toggle (show/hide)

Updates the JavaScript to change the button label from Show Improvements/Triaged to Hide when appropriate. Also adds a slight background change to improve usability.

Updated UI:
http://i.imgur.com/6bWJcqZ.png


BUG=catapult:#1689

Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/8b652f81afa9d8b8426c9017e298307c46df62ff

[jessimb, 2016-11-15 18:07:17]

Description was changed from

==========
Coding style adjustments.


BUG=catapult:#1689
==========

to

==========
Updates the JavaScript to change the button label from Show Improvements/Triaged
to Hide when appropriate. Also adds a slight background change to improve
usability. 


BUG=catapult:#1689
==========

[jessimb, 2016-11-15 18:07:17]

jessimb@chromium.org changed reviewers:
+ eakuefner@chromium.org

[eakuefner, 2016-11-15 18:14:22]

Looking good, some suggestions:

1. I recommend titling your CL to describe an action, e.g. "Change alerts-page
buttons to be X instead of Y"
2. For UI changes like this, it can be a good idea to link screenshots in your
CL description.

https://codereview.chromium.org/2495253004/diff/40001/dashboard/dashboard/ele...
File dashboard/dashboard/elements/alerts-page.html (right):

https://codereview.chromium.org/2495253004/diff/40001/dashboard/dashboard/ele...
dashboard/dashboard/elements/alerts-page.html:98:
{{getLabel(showingImprovements)}} improvements
nit: this should be indented two spaces from the < in <paper-button... and the
closing tag should be aligned with the open tag.

https://codereview.chromium.org/2495253004/diff/40001/dashboard/dashboard/ele...
dashboard/dashboard/elements/alerts-page.html:212: getLabel:
function(toggleState) {
nit: please write this as an arrow:

toggleState => toggleState ? 'hide' : 'show'

[jessimb, 2016-11-15 18:57:55]

On 2016/11/15 at 18:14:22, eakuefner wrote:
> Looking good, some suggestions:
> 
> 1. I recommend titling your CL to describe an action, e.g. "Change alerts-page
buttons to be X instead of Y"
> 2. For UI changes like this, it can be a good idea to link screenshots in your
CL description.
> 
>
https://codereview.chromium.org/2495253004/diff/40001/dashboard/dashboard/ele...
> File dashboard/dashboard/elements/alerts-page.html (right):
> 
>
https://codereview.chromium.org/2495253004/diff/40001/dashboard/dashboard/ele...
> dashboard/dashboard/elements/alerts-page.html:98:
{{getLabel(showingImprovements)}} improvements
> nit: this should be indented two spaces from the < in <paper-button... and the
closing tag should be aligned with the open tag.
> 
>
https://codereview.chromium.org/2495253004/diff/40001/dashboard/dashboard/ele...
> dashboard/dashboard/elements/alerts-page.html:212: getLabel:
function(toggleState) {
> nit: please write this as an arrow:
> 
> toggleState => toggleState ? 'hide' : 'show'

Done.

[jessimb, 2016-11-15 19:11:33]

Also, here is the new state of the buttons:
http://imgur.com/a/behHN

[eakuefner, 2016-11-15 19:15:07]

On 2016/11/15 at 19:11:33, jessimb wrote:
> Also, here is the new state of the buttons:
> http://imgur.com/a/behHN

Can you add the direct link http://i.imgur.com/8nUE5jJ.png to the CL
description?

Also, can we maybe try a gray that's a little darker? At least in the
screenshot, the difference is so slight that it's a little difficult for me to
see it.

[jessimb, 2016-11-15 19:24:22]

Description was changed from

==========
Updates the JavaScript to change the button label from Show Improvements/Triaged
to Hide when appropriate. Also adds a slight background change to improve
usability. 


BUG=catapult:#1689
==========

to

==========
Updates the JavaScript to change the button label from Show Improvements/Triaged
to Hide when appropriate. Also adds a slight background change to improve
usability.

Updated UI:
http://imgur.com/a/n7dN6 


BUG=catapult:#1689
==========

[jessimb, 2016-11-15 19:24:46]

Description was changed from

==========
Updates the JavaScript to change the button label from Show Improvements/Triaged
to Hide when appropriate. Also adds a slight background change to improve
usability.

Updated UI:
http://imgur.com/a/n7dN6 


BUG=catapult:#1689
==========

to

==========
Updates the JavaScript to change the button label from Show Improvements/Triaged
to Hide when appropriate. Also adds a slight background change to improve
usability.

Updated UI:
<img href='http://imgur.com/a/n7dN6'>


BUG=catapult:#1689
==========

[jessimb, 2016-11-15 19:24:57]

Description was changed from

==========
Updates the JavaScript to change the button label from Show Improvements/Triaged
to Hide when appropriate. Also adds a slight background change to improve
usability.

Updated UI:
<img href='http://imgur.com/a/n7dN6'>


BUG=catapult:#1689
==========

to

==========
Updates the JavaScript to change the button label from Show Improvements/Triaged
to Hide when appropriate. Also adds a slight background change to improve
usability.

Updated UI:
<img href='http://imgur.com/a/n7dN6'/>


BUG=catapult:#1689
==========

[jessimb, 2016-11-15 19:25:12]

Description was changed from

==========
Updates the JavaScript to change the button label from Show Improvements/Triaged
to Hide when appropriate. Also adds a slight background change to improve
usability.

Updated UI:
<img href='http://imgur.com/a/n7dN6'/>


BUG=catapult:#1689
==========

to

==========
Updates the JavaScript to change the button label from Show Improvements/Triaged
to Hide when appropriate. Also adds a slight background change to improve
usability.

Updated UI:
<img src='http://imgur.com/a/n7dN6'/>


BUG=catapult:#1689
==========

[jessimb, 2016-11-15 19:25:22]

Description was changed from

==========
Updates the JavaScript to change the button label from Show Improvements/Triaged
to Hide when appropriate. Also adds a slight background change to improve
usability.

Updated UI:
<img src='http://imgur.com/a/n7dN6'/>


BUG=catapult:#1689
==========

to

==========
Updates the JavaScript to change the button label from Show Improvements/Triaged
to Hide when appropriate. Also adds a slight background change to improve
usability.

Updated UI:
<img src='http://imgur.com/a/n7dN6'>


BUG=catapult:#1689
==========

[jessimb, 2016-11-15 19:26:25]

Description was changed from

==========
Updates the JavaScript to change the button label from Show Improvements/Triaged
to Hide when appropriate. Also adds a slight background change to improve
usability.

Updated UI:
<img src='http://imgur.com/a/n7dN6'>


BUG=catapult:#1689
==========

to

==========
Updates the JavaScript to change the button label from Show Improvements/Triaged
to Hide when appropriate. Also adds a slight background change to improve
usability.

Updated UI:
http://i.imgur.com/6bWJcqZ.png


BUG=catapult:#1689
==========

[jessimb, 2016-11-15 19:32:33]

On 2016/11/15 at 19:15:07, eakuefner wrote:
> On 2016/11/15 at 19:11:33, jessimb wrote:
> > Also, here is the new state of the buttons:
> > http://imgur.com/a/behHN
> 
> Can you add the direct link http://i.imgur.com/8nUE5jJ.png to the CL
description?
> 
> Also, can we maybe try a gray that's a little darker? At least in the
screenshot, the difference is so slight that it's a little difficult for me to
see it.

Done. I don't want to go much darker than the update (in the description) and
draw the eye away from the important information on the page. The button now
matches the div above it.

[eakuefner, 2016-11-15 20:03:33]

eakuefner@chromium.org changed reviewers:
+ sullivan@chromium.org

[eakuefner, 2016-11-15 20:03:33]

+Annie for dashboard/ OWNERS

lgtm

[sullivan, 2016-11-15 21:53:38]

lgtm

[jessimb, 2016-11-15 22:07:41]

The CQ bit was checked by jessimb@chromium.org

[commit-bot: I haz the power, 2016-11-15 22:07:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-15 22:29:49]

Description was changed from

==========
Updates the JavaScript to change the button label from Show Improvements/Triaged
to Hide when appropriate. Also adds a slight background change to improve
usability.

Updated UI:
http://i.imgur.com/6bWJcqZ.png


BUG=catapult:#1689
==========

to

==========
Updates the JavaScript to change the button label from Show Improvements/Triaged
to Hide when appropriate. Also adds a slight background change to improve
usability.

Updated UI:
http://i.imgur.com/6bWJcqZ.png


BUG=catapult:#1689

Committed:
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...
==========

[commit-bot: I haz the power, 2016-11-15 22:29:50]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...