Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issue 2495253004: Changes alerts page buttons to reflect state of toggle (show/hide) (Closed)

Created:
4 years, 1 month ago by jessimb
Modified:
4 years, 1 month ago
Reviewers:
eakuefner, sullivan
CC:
catapult-reviews_chromium.org, perf-dashboard-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

Updates the JavaScript to change the button label from Show Improvements/Triaged to Hide when appropriate. Also adds a slight background change to improve usability. Updated UI: http://i.imgur.com/6bWJcqZ.png BUG=catapult:#1689 Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/8b652f81afa9d8b8426c9017e298307c46df62ff

Patch Set 1 #

Patch Set 2 : removing dead code #

Patch Set 3 : removing newline #

Total comments: 2

Patch Set 4 : response to eakuefners comments #

Patch Set 5 : darker button color #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -2 lines) Patch
M dashboard/dashboard/elements/alerts-page.html View 1 2 3 4 3 chunks +12 lines, -2 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 21 (11 generated)
jessimb
4 years, 1 month ago (2016-11-15 18:07:34 UTC) #3
eakuefner
Looking good, some suggestions: 1. I recommend titling your CL to describe an action, e.g. ...
4 years, 1 month ago (2016-11-15 18:14:22 UTC) #4
jessimb
On 2016/11/15 at 18:14:22, eakuefner wrote: > Looking good, some suggestions: > > 1. I ...
4 years, 1 month ago (2016-11-15 18:57:55 UTC) #5
jessimb
Also, here is the new state of the buttons: http://imgur.com/a/behHN
4 years, 1 month ago (2016-11-15 19:11:33 UTC) #6
eakuefner
On 2016/11/15 at 19:11:33, jessimb wrote: > Also, here is the new state of the ...
4 years, 1 month ago (2016-11-15 19:15:07 UTC) #7
jessimb
On 2016/11/15 at 19:15:07, eakuefner wrote: > On 2016/11/15 at 19:11:33, jessimb wrote: > > ...
4 years, 1 month ago (2016-11-15 19:32:33 UTC) #14
eakuefner
+Annie for dashboard/ OWNERS lgtm
4 years, 1 month ago (2016-11-15 20:03:33 UTC) #16
sullivan
lgtm
4 years, 1 month ago (2016-11-15 21:53:38 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2495253004/80001
4 years, 1 month ago (2016-11-15 22:07:57 UTC) #19
commit-bot: I haz the power
4 years, 1 month ago (2016-11-15 22:29:50 UTC) #21
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

Powered by Google App Engine
This is Rietveld 408576698