Only label milestones for ChromiumPerf and ChromiumPerfFyi and corresponding test.

Only label milestones for ChromiumPerf and ChromiumPerfFyi and corresponding test.

BUG=catapult:#2906

Review-Url: https://codereview.chromium.org/2618413002
Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/0923694288b735f9e79b7647eeebb628c459841c

[jessimb, 2017-01-09 20:20:22]

jessimb@chromium.org changed reviewers:
+ eakuefner@chromium.org

[jessimb, 2017-01-09 20:20:22]

PTAL

[sullivan, 2017-01-09 20:22:10]

sullivan@chromium.org changed reviewers:
+ sullivan@chromium.org

[sullivan, 2017-01-09 20:22:11]

https://codereview.chromium.org/2618413002/diff/20001/dashboard/dashboard/fil...
File dashboard/dashboard/file_bug.py (right):

https://codereview.chromium.org/2618413002/diff/20001/dashboard/dashboard/fil...
dashboard/dashboard/file_bug.py:240: master =
utils.TestPath(alerts[0].GetTestMetadataKey()).split('/')[0]
It's possible there are different masters in the same group of alerts. I think
we should use the alert for min_revision instead of alerts[0].

[jessimb, 2017-01-09 21:07:24]

@sullivan
PTAL, I dislike the extra for loop in there, but now we will check the master
for each alert that has the min(revisions) as it's start_rev (in case many
alerts have the same start_rev). 
I'm not sure if I should add a 'break' after the end of the inner for loop so we
only perform this check once instead of iterating through all the alerts again.

[sullivan, 2017-01-09 22:17:48]

lgtm

I think this is okay. Another alternative would be to do a single loop like we
used to do before list comprehensions that tracks the current lowest (revision,
master) pair, but I don't think it would be substantially cleaner.

https://codereview.chromium.org/2618413002/diff/40001/dashboard/dashboard/fil...
File dashboard/dashboard/file_bug.py (right):

https://codereview.chromium.org/2618413002/diff/40001/dashboard/dashboard/fil...
dashboard/dashboard/file_bug.py:243: return None
Yeah, i think it would be good to add a break.

[eakuefner, 2017-01-09 22:29:14]

lgtm

https://codereview.chromium.org/2618413002/diff/50001/dashboard/dashboard/fil...
File dashboard/dashboard/file_bug.py (right):

https://codereview.chromium.org/2618413002/diff/50001/dashboard/dashboard/fil...
dashboard/dashboard/file_bug.py:232: Chromium Milestones, do not label them (see
bug #2906).
nit: milestones doesn't need to be capitalized. also, can you link to the bug?

[jessimb, 2017-01-09 22:47:55]

The CQ bit was checked by jessimb@chromium.org

[jessimb, 2017-01-09 22:47:56]

The patchset sent to the CQ was uploaded after l-g-t-m from
sullivan@chromium.org, eakuefner@chromium.org
Link to the patchset: https://codereview.chromium.org/2618413002/#ps70001
(title: "Fix comments")

[commit-bot: I haz the power, 2017-01-09 22:48:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-09 23:07:46]

CQ is committing da patch.

Bot data: {"patchset_id": 70001, "attempt_start_ts": 1484002075533980,
"parent_rev": "3117a26ce459be98f34a94cf0437ad5e300c21e3", "commit_rev":
"0923694288b735f9e79b7647eeebb628c459841c"}

[commit-bot: I haz the power, 2017-01-09 23:07:49]

Description was changed from

==========
Only label milestones for ChromiumPerf and ChromiumPerfFyi and corresponding
test.

BUG=catapult:#2906
==========

to

==========
Only label milestones for ChromiumPerf and ChromiumPerfFyi and corresponding
test.

BUG=catapult:#2906

Review-Url: https://codereview.chromium.org/2618413002
Committed:
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...
==========

[commit-bot: I haz the power, 2017-01-09 23:07:50]

Committed patchset #5 (id:70001) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...