Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(282)

Unified Diff: dashboard/dashboard/elements/alerts-page.html

Issue 2495253004: Changes alerts page buttons to reflect state of toggle (show/hide) (Closed)
Patch Set: darker button color Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: dashboard/dashboard/elements/alerts-page.html
diff --git a/dashboard/dashboard/elements/alerts-page.html b/dashboard/dashboard/elements/alerts-page.html
index b6b1e033bdb472a4c50be405054b2c840a1562be..c9577726d9f10e9fd53451fd11ef3209136c8116 100644
--- a/dashboard/dashboard/elements/alerts-page.html
+++ b/dashboard/dashboard/elements/alerts-page.html
@@ -53,6 +53,10 @@ found in the LICENSE file.
margin-right: 4px;
}
+ .alert-togglebutton[active] {
+ background-color: #EEE;
+ }
+
#auto-triage-log {
padding: 15px 0 15px 0;
}
@@ -90,11 +94,15 @@ found in the LICENSE file.
<paper-button raised noink id="improvements-toggle"
class="alert-togglebutton"
active$="{{showingImprovements}}"
- on-click="onToggleImprovements">Show improvements</paper-button>
+ on-click="onToggleImprovements">
+ {{getLabel(showingImprovements)}} improvements
+ </paper-button>
<paper-button raised noink id="triaged-toggle"
class="alert-togglebutton"
active$="{{showingTriaged}}"
- on-click="onToggleTriaged">Show triaged</paper-button>
+ on-click="onToggleTriaged">
+ {{getLabel(showingTriaged)}} triaged
+ </paper-button>
</div>
<template is="dom-if" if="{{anomalies.length}}">
<h2>Performance alerts</h2>
@@ -201,6 +209,8 @@ found in the LICENSE file.
computeIsSingular: array => array.length === 1,
+ getLabel: toggleState => toggleState ? 'hide' : 'show',
+
onSheriffChange: function(e) {
var sheriff = e.detail.item.label;
if (!sheriff) {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698