Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(485)

Issue 2524473002: Fixes sorting on alerts tables when dealing with grouped alerts. (Closed)

Created:
4 years ago by jessimb
Modified:
4 years ago
Reviewers:
eakuefner, sullivan
CC:
catapult-reviews_chromium.org, perf-dashboard-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

Updates alerts-table (on dashboard and group-reports) to sort correctly. Sorts the inner groups first, then sorts based on the highest/lowest in each group. Also added a few alerts to the alerts-page-test to convince myself that this works correctly. Collapsed view: http://i.imgur.com/ukc4BIk.png Expanded view: http://i.imgur.com/jDsj4I6.png BUG=catapult:#2774 Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/982d024dadecb5a6b73041f349dd0032c532967e

Patch Set 1 #

Patch Set 2 : cleaning up code/logic #

Total comments: 8

Patch Set 3 : code review response #

Unified diffs Side-by-side diffs Delta from patch set Stats (+103 lines, -30 lines) Patch
M dashboard/dashboard/elements/alerts-page-test.html View 1 chunk +57 lines, -0 lines 0 comments Download
M dashboard/dashboard/elements/alerts-table.html View 1 2 4 chunks +46 lines, -30 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 13 (6 generated)
jessimb
PTAL
4 years ago (2016-11-21 20:58:56 UTC) #3
eakuefner
Looking good, just a few comments/questions. https://codereview.chromium.org/2524473002/diff/20001/dashboard/dashboard/elements/alerts-table.html File dashboard/dashboard/elements/alerts-table.html (right): https://codereview.chromium.org/2524473002/diff/20001/dashboard/dashboard/elements/alerts-table.html#newcode528 dashboard/dashboard/elements/alerts-table.html:528: for (var i ...
4 years ago (2016-11-23 16:33:21 UTC) #4
jessimb
PTAL https://codereview.chromium.org/2524473002/diff/20001/dashboard/dashboard/elements/alerts-table.html File dashboard/dashboard/elements/alerts-table.html (right): https://codereview.chromium.org/2524473002/diff/20001/dashboard/dashboard/elements/alerts-table.html#newcode528 dashboard/dashboard/elements/alerts-table.html:528: for (var i = 0; i < this.alertList.length; ...
4 years ago (2016-11-23 17:08:09 UTC) #5
eakuefner
lgtm, +Annie for OWNERS
4 years ago (2016-11-23 17:17:49 UTC) #7
sullivan
lgtm
4 years ago (2016-11-23 17:23:17 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2524473002/40001
4 years ago (2016-11-23 17:23:22 UTC) #10
commit-bot: I haz the power
4 years ago (2016-11-23 17:41:56 UTC) #13
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

Powered by Google App Engine
This is Rietveld 408576698