Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Issue 2644013004: Updates milestone label to use r_commit_pos if available. (Closed)

Created:
3 years, 11 months ago by jessimb
Modified:
3 years, 11 months ago
Reviewers:
eakuefner, sullivan
CC:
catapult-reviews_chromium.org, perf-dashboard-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

Updates milestone label to use r_commit_pos if available. This CL checks that we are only labeling alerts that have r_commit_pos (and therefore are chromium commits). Added corresponding tests. BUG=catapult:#2906 Review-Url: https://codereview.chromium.org/2644013004 Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/93b0aba2c21fd2852645db88beaf62d13364b812

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+80 lines, -30 lines) Patch
M dashboard/dashboard/common/utils.py View 1 chunk +4 lines, -0 lines 0 comments Download
M dashboard/dashboard/file_bug.py View 2 chunks +11 lines, -9 lines 0 comments Download
M dashboard/dashboard/file_bug_test.py View 5 chunks +65 lines, -21 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 8 (4 generated)
jessimb
PTAL. Should probably wait until @perezju agrees that end_revision is an okay change to make.
3 years, 11 months ago (2017-01-19 22:18:40 UTC) #2
sullivan
lgtm Thanks!
3 years, 11 months ago (2017-01-19 22:30:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2644013004/1
3 years, 11 months ago (2017-01-20 18:49:27 UTC) #5
commit-bot: I haz the power
3 years, 11 months ago (2017-01-20 19:10:09 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

Powered by Google App Engine
This is Rietveld 408576698