Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 2520963003: Adding a counter to data stoppage alerts (Closed)

Created:
4 years, 1 month ago by jessimb
Modified:
4 years, 1 month ago
Reviewers:
eakuefner, sullivan
CC:
catapult-reviews_chromium.org, perf-dashboard-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

The performance alerts have a counter of how many alerts there are. Now data stoppage alerts also have a counter. Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/d10b57bde75883f4d2281353f5f1976467ecd542

Patch Set 1 #

Patch Set 2 : removed unncessary id #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M dashboard/dashboard/elements/alerts-page.html View 1 1 chunk +3 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 13 (9 generated)
jessimb
It bothered me that there was a counter for only perf alerts, so I added ...
4 years, 1 month ago (2016-11-22 02:05:14 UTC) #6
sullivan
lgtm Thanks!
4 years, 1 month ago (2016-11-22 14:55:19 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2520963003/20001
4 years, 1 month ago (2016-11-22 17:12:02 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-11-22 17:13:21 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

Powered by Google App Engine
This is Rietveld 408576698