Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(431)

Issue 2493913002: Mus: Move InProcessCommandBuffer and GLInProcessContext to gpu/ipc (Closed)

Created:
4 years, 1 month ago by Fady Samuel
Modified:
4 years, 1 month ago
CC:
chromium-reviews, droger+watchlist_chromium.org, blundell+watchlist_chromium.org, nyquist+watch-blimp_chromium.org, kmarshall+watch-blimp_chromium.org, shaktisahu+watch-blimp_chromium.org, maniscalco+watch-blimp_chromium.org, bgoldman+watch-blimp_chromium.org, sdefresne+watchlist_chromium.org, gcasto+watch-blimp_chromium.org, jbauman+watch_chromium.org, marcinjb+watch-blimp_chromium.org, lethalantidote+watch-blimp_chromium.org, kalyank, scf+watch-blimp_chromium.org, piman+watch_chromium.org, cc-bugs_chromium.org, khushalsagar+watch-blimp_chromium.org, anandc+watch-blimp_chromium.org, sriramsr+watch-blimp_chromium.org, Ian Vollick, steimel+watch-blimp_chromium.org, android-webview-reviews_chromium.org, perumaal+watch-blimp_chromium.org, danakj+watch_chromium.org, dtrainor+watch-blimp_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mus: Move InProcessCommandBuffer and GLInProcessContext to gpu/ipc We would like to use InProcessCommandBuffer and GLInProcessContext in mus-gpu. In a subsequent patch, InProcessCommandBuffer will use PassThroughImageTransportSurface in order to receive notification of when a SwapBuffers completes and latency info, among other things. PassThroughImageTransportSurface lives in gpu/ipc/service. gpu/command_buffer/service cannot depend on gpu/ipc/service. Thus, we move this code to gpu/ipc where it can depend on both gpu/command_buffer/{client, common, service} and gpu/ipc/{client, common, service} BUG=661278 TBR=sky@chromium.org for ui, danakj@chromium.org for display_compositor/cc, boliu@chromium.org for android_webview, dtrainor@chromium.org for blimp. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Committed: https://crrev.com/600b99ea4e897ae59eb10828e452a00a80e9c581 Cr-Commit-Position: refs/heads/master@{#431519}

Patch Set 1 #

Patch Set 2 : Added missing BUILD.gn file #

Patch Set 3 : Fix some deps #

Patch Set 4 : Fixed Android deps #

Patch Set 5 : Make public_deps #

Patch Set 6 : Fix some sad bots #

Patch Set 7 : Try to fix mac #

Patch Set 8 : Make CommandBuffer part of GPU Component #

Patch Set 9 : Rebase #

Patch Set 10 : Fixed casts on windows #

Unified diffs Side-by-side diffs Delta from patch set Stats (+119 lines, -1788 lines) Patch
M android_webview/BUILD.gn View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M android_webview/browser/aw_render_thread_context_provider.h View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/browser/aw_render_thread_context_provider.cc View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/browser/deferred_gpu_command_service.h View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/lib/main/aw_main_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M blimp/client/support/compositor/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M blimp/client/support/compositor/blimp_context_provider.h View 1 chunk +1 line, -1 line 0 comments Download
M blimp/client/support/compositor/blimp_context_provider.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/BUILD.gn View 1 2 3 4 5 6 7 8 1 chunk +1 line, -1 line 0 comments Download
M cc/test/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M cc/test/layer_tree_pixel_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/test/test_in_process_context_provider.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/display_compositor/BUILD.gn View 3 chunks +3 lines, -3 lines 0 comments Download
M components/display_compositor/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M components/display_compositor/gl_helper_benchmark.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/display_compositor/gl_helper_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/display_compositor/yuv_readback_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M gpu/BUILD.gn View 1 2 3 4 5 6 7 3 chunks +3 lines, -2 lines 0 comments Download
M gpu/command_buffer/client/BUILD.gn View 1 chunk +0 lines, -20 lines 0 comments Download
D gpu/command_buffer/client/gl_in_process_context.h View 1 chunk +0 lines, -70 lines 0 comments Download
D gpu/command_buffer/client/gl_in_process_context.cc View 1 chunk +0 lines, -212 lines 0 comments Download
D gpu/command_buffer/client/gl_in_process_context_export.h View 1 chunk +0 lines, -29 lines 0 comments Download
M gpu/command_buffer/service/BUILD.gn View 1 2 3 4 5 6 7 8 1 chunk +0 lines, -2 lines 0 comments Download
D gpu/command_buffer/service/in_process_command_buffer.h View 1 chunk +0 lines, -315 lines 0 comments Download
D gpu/command_buffer/service/in_process_command_buffer.cc View 1 2 3 4 5 6 7 8 1 chunk +0 lines, -1077 lines 0 comments Download
A gpu/ipc/BUILD.gn View 1 2 3 4 5 6 7 1 chunk +60 lines, -0 lines 0 comments Download
M gpu/ipc/client/gpu_in_process_context_tests.cc View 1 chunk +1 line, -1 line 0 comments Download
A + gpu/ipc/gl_in_process_context.h View 3 chunks +4 lines, -4 lines 0 comments Download
A + gpu/ipc/gl_in_process_context.cc View 1 chunk +1 line, -1 line 0 comments Download
A + gpu/ipc/gl_in_process_context_export.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + gpu/ipc/in_process_command_buffer.h View 3 chunks +4 lines, -4 lines 0 comments Download
A + gpu/ipc/in_process_command_buffer.cc View 1 2 3 4 5 6 7 8 9 14 chunks +25 lines, -33 lines 0 comments Download
M ui/compositor/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M ui/compositor/test/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M ui/compositor/test/in_process_context_provider.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 65 (42 generated)
Fady Samuel
This is largely a mechanical move. In a subsequent CL, I'll use ImageTransportSurfaceDelegate in InProcessCommandBuffer.
4 years, 1 month ago (2016-11-10 21:46:09 UTC) #6
vmiura
Missing .gn configs for gpu/ipc/gl_in_process_context.cc & co?
4 years, 1 month ago (2016-11-10 22:13:46 UTC) #17
piman
lgtm % build stuff
4 years, 1 month ago (2016-11-10 22:24:20 UTC) #21
Fady Samuel
+sky@ for ui +danakj@ for display_compositor + cc +boliu@ for android_webview +dtrainor@ for blimp I'm ...
4 years, 1 month ago (2016-11-10 22:27:45 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2493913002/80001
4 years, 1 month ago (2016-11-10 22:38:06 UTC) #27
vmiura
gpu/ lgtm
4 years, 1 month ago (2016-11-10 22:55:42 UTC) #28
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg_ng/builds/303825)
4 years, 1 month ago (2016-11-10 22:57:01 UTC) #30
danakj
LGTM if others are ok with it. It's weird that in-process thing is in the ...
4 years, 1 month ago (2016-11-10 22:58:25 UTC) #31
Fady Samuel
On 2016/11/10 22:58:25, danakj wrote: > LGTM if others are ok with it. It's weird ...
4 years, 1 month ago (2016-11-10 22:59:52 UTC) #32
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2493913002/100001
4 years, 1 month ago (2016-11-10 23:44:18 UTC) #35
commit-bot: I haz the power
Try jobs failed on following builders: android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_compile_dbg/builds/162334)
4 years, 1 month ago (2016-11-10 23:57:47 UTC) #37
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2493913002/120001
4 years, 1 month ago (2016-11-11 00:00:33 UTC) #40
sky
LGTM
4 years, 1 month ago (2016-11-11 00:33:59 UTC) #41
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_compile_dbg_ng/builds/294443)
4 years, 1 month ago (2016-11-11 00:36:25 UTC) #43
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2493913002/140001
4 years, 1 month ago (2016-11-11 04:55:12 UTC) #46
commit-bot: I haz the power
Try jobs failed on following builders: blimp_linux_dbg on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/blimp_linux_dbg/builds/30921)
4 years, 1 month ago (2016-11-11 04:57:57 UTC) #48
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2493913002/160001
4 years, 1 month ago (2016-11-11 05:28:56 UTC) #51
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/315426)
4 years, 1 month ago (2016-11-11 06:30:56 UTC) #53
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2493913002/180001
4 years, 1 month ago (2016-11-11 06:34:37 UTC) #56
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2493913002/200001
4 years, 1 month ago (2016-11-11 06:49:09 UTC) #59
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/333488)
4 years, 1 month ago (2016-11-11 06:51:10 UTC) #61
commit-bot: I haz the power
Committed patchset #10 (id:180001)
4 years, 1 month ago (2016-11-11 07:50:57 UTC) #63
commit-bot: I haz the power
4 years, 1 month ago (2016-11-11 07:55:34 UTC) #65
Message was sent while issue was closed.
Patchset 10 (id:??) landed as
https://crrev.com/600b99ea4e897ae59eb10828e452a00a80e9c581
Cr-Commit-Position: refs/heads/master@{#431519}

Powered by Google App Engine
This is Rietveld 408576698