Synchronize OffscreenCanvas content with the placeholder canvas

Synchronize OffscreenCanvas content with the placeholder canvas

This change solves the problem of propagating frames committed by
an OffscreenCanvas all the way to the placeholder canvas, whether it
be in the same script context or not.

This allows the placeholder canvas to be used as an image source,
and to be printed.

BUG=655278
TBR=kbr@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/20ba52f0f6249c418d90244e3b7b1d8b317c30a4
Cr-Commit-Position: refs/heads/master@{#431953}

[Justin Novosad, 2016-11-10 00:08:47]

Description was changed from

==========
Synchronize OffscreenCanvas content with the placeholder canvas

This change solves the problem of propagating frames committed by
an OffscreenCanvas all the way to the placeholder canvas, whether it
be in the same script context or not.

This allows the placeholder canvas to be used as an image source,
and to be printed.

BUG=655278
==========

to

==========
Synchronize OffscreenCanvas content with the placeholder canvas

This change solves the problem of propagating frames committed by
an OffscreenCanvas all the way to the placeholder canvas, whether it
be in the same script context or not.

This allows the placeholder canvas to be used as an image source,
and to be printed.

BUG=655278
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Justin Novosad, 2016-11-10 18:52:01]

The CQ bit was checked by junov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-10 18:52:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Justin Novosad, 2016-11-10 18:54:30]

junov@chromium.org changed reviewers:
+ xidachen@chromium.org, xlai@chromium.org

[Justin Novosad, 2016-11-10 18:54:31]

PTAL

[commit-bot: I haz the power, 2016-11-10 18:56:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-10 18:56:10]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
  mac_optional_gpu_tests_rel on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_optional_gpu_...)

[Justin Novosad, 2016-11-10 20:14:42]

The CQ bit was checked by junov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-10 20:15:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-10 20:41:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-10 20:41:42]

Dry run: Try jobs failed on following builders:
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)

[Justin Novosad, 2016-11-10 21:25:10]

The CQ bit was checked by junov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-10 21:25:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-10 21:34:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-10 21:34:47]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[xlai (Olivia), 2016-11-11 16:28:33]

https://codereview.chromium.org/2493673002/diff/40001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/platform/graphics/OffscreenCanvasFrameDispatcherImpl.cpp
(right):

https://codereview.chromium.org/2493673002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/graphics/OffscreenCanvasFrameDispatcherImpl.cpp:241:
image->transfer();
In the case of gpu-accelerated offscreencanvas, this image is kept as a resource
in OffscreenCanvasFrameDispatcher in worker. I'm not sure if you transferring it
to main thread here will cause any trouble.

https://codereview.chromium.org/2493673002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/graphics/OffscreenCanvasFrameDispatcherImpl.cpp:245:
Platform::current()->mainThread()->getWebTaskRunner()->postTask(
This dispatchFrame() is invoked in every commit(). Whilst I understand that you
need to refresh the new frame and resource id for every commit(), you may end up
posting certain duplicate information of (dispatcherTaskRunner,
this->createWeakPtr()) to the main thread repeatedly. This is an overhead that
may become more and more painful when there are lots of commit().

A better place to send the dispatcherTaskRunner and this->createWeakPtr() should
be in OffscreenCanvas::getContext(), which is guaranteed to be invoked once in a
lifetime of an OffscreenCanvas.

https://codereview.chromium.org/2493673002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/graphics/OffscreenCanvasPlaceholder.cpp
(right):

https://codereview.chromium.org/2493673002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/graphics/OffscreenCanvasPlaceholder.cpp:23:
void releaseFrameToDispatcher(
Is there any reason why you put this function in an unnamed namespace instead of
a member function in OffscreenCanvasFrameDispatcher?

https://codereview.chromium.org/2493673002/diff/60001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/printing/offscreencanvas-2d-printing.html
(right):

https://codereview.chromium.org/2493673002/diff/60001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/printing/offscreencanvas-2d-printing.html:9:
ctx.commit();
Great. Although the compositorFrame submmitted to browser is still not processed
in layout tests, at least after this CL we can retrieve the image information on
the main thread.

[xidachen, 2016-11-11 16:54:01]

I have a high-level comment:
With this patch, we are always sending resources from worker-->main thread.
However, this step is not needed if the placeholder canvas is not used as an
imagesource. So what I would suggest is this:
When the placeholder canvas is used as an imagesource, we send a message to the
worker thread to request the resources.

I don't know how much work this is, and what kind of corner cases we might hit.
Since this is a performance-related issue, I wouldn't put it as urgent to solve.

https://codereview.chromium.org/2493673002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp (right):

https://codereview.chromium.org/2493673002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp:35: #include
"core/dom/DOMNodeIds.h"
Do we need to include this header here?

[xlai (Olivia), 2016-11-11 20:49:35]

On 2016/11/11 16:54:01, xidachen wrote:
> I have a high-level comment:
> With this patch, we are always sending resources from worker-->main thread.
> However, this step is not needed if the placeholder canvas is not used as an
> imagesource. So what I would suggest is this:
> When the placeholder canvas is used as an imagesource, we send a message to
the
> worker thread to request the resources.
> 
> I don't know how much work this is, and what kind of corner cases we might
hit.
> Since this is a performance-related issue, I wouldn't put it as urgent to
solve.
> 

I think I agree with Xida that postMessage for every commit() may cause
some overhead, especially when the user does not intend to do printing and
there're
lots of commits(). My concern is that we may queue a lot of tasks to the main
thread,
and these tasks are quickly becoming irrelevant as the frame is changing.

How about this:
1) Having a postMessage on OffscreenCanvas.getContext() (or other similar
function that's
invoked once in a lifetime) to communicate the weak pointer and taskRunner back
to 
main thread.
2) Let HTMLCanvasElement decide when to retrieve image from OffscreenCanvas
(e.g., when
printing happens) and once it is, postMessage to worker to request the image and
the OffscreenCanvas
on worker will do what's implemented here. But this might be a problem to
toDataURL(),
which is synchronous...Hmmm..

[Justin Novosad, 2016-11-11 22:08:39]

The CQ bit was checked by junov@chromium.org to run a CQ dry run

[Justin Novosad, 2016-11-11 22:09:00]

https://codereview.chromium.org/2493673002/diff/40001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/platform/graphics/OffscreenCanvasFrameDispatcherImpl.cpp
(right):

https://codereview.chromium.org/2493673002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/graphics/OffscreenCanvasFrameDispatcherImpl.cpp:241:
image->transfer();
On 2016/11/11 16:28:33, xlai (Olivia) wrote:
> In the case of gpu-accelerated offscreencanvas, this image is kept as a
resource
> in OffscreenCanvasFrameDispatcher in worker. I'm not sure if you transferring
it
> to main thread here will cause any trouble.

The idea is that We don't need to use this snapshot on the worker except for
when comes the time to delete the resource. So this should be fine.
Except that I was missing the reciprocal transfer in
OffscreenCanvasPlaceholder::releasePlaceholderFrame.  That is fixed now.

https://codereview.chromium.org/2493673002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/graphics/OffscreenCanvasFrameDispatcherImpl.cpp:245:
Platform::current()->mainThread()->getWebTaskRunner()->postTask(
On 2016/11/11 16:28:33, xlai (Olivia) wrote:
> This dispatchFrame() is invoked in every commit(). Whilst I understand that
you
> need to refresh the new frame and resource id for every commit(), you may end
up
> posting certain duplicate information of (dispatcherTaskRunner,
> this->createWeakPtr()) to the main thread repeatedly. This is an overhead that
> may become more and more painful when there are lots of commit().
> 
> A better place to send the dispatcherTaskRunner and this->createWeakPtr()
should
> be in OffscreenCanvas::getContext(), which is guaranteed to be invoked once in
a
> lifetime of an OffscreenCanvas.

I tried that and it is actually more complicated with no real reduction in
overhead.  The problem is that if OffscreenCanvasPlaceholder retains a
long-lived WeakPtr, then it can't std::move the weakptr when posting the call to
releaseFrameToDispatcher.  To solve that, you'd have to pass a weakPtr to the
OffscreenCanvasPlaceholder so that we can access m_frameDispatcherTaskRunner. 
And we're right back where we were, creating a weakPtr at every frame, except
that now, we've also added a weakptr factory on OffscreenCanvasPlaceholder.

https://codereview.chromium.org/2493673002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/graphics/OffscreenCanvasPlaceholder.cpp
(right):

https://codereview.chromium.org/2493673002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/graphics/OffscreenCanvasPlaceholder.cpp:23:
void releaseFrameToDispatcher(
On 2016/11/11 16:28:33, xlai (Olivia) wrote:
> Is there any reason why you put this function in an unnamed namespace instead
of
> a member function in OffscreenCanvasFrameDispatcher?

I can't put it in OffscreenCanvasFrameDispatcher because we have to check the
weakptr before calling into the dispatcher.

https://codereview.chromium.org/2493673002/diff/60001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/printing/offscreencanvas-2d-printing.html
(right):

https://codereview.chromium.org/2493673002/diff/60001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/printing/offscreencanvas-2d-printing.html:9:
ctx.commit();
On 2016/11/11 16:28:33, xlai (Olivia) wrote:
> Great. Although the compositorFrame submmitted to browser is still not
processed
> in layout tests, at least after this CL we can retrieve the image information
on
> the main thread.

This test only aims to test printing, what happens with the browser compositor
is of no consequence for this particular case.  Printing happens entirely in the
renderer.

https://codereview.chromium.org/2493673002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp (right):

https://codereview.chromium.org/2493673002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp:35: #include
"core/dom/DOMNodeIds.h"
On 2016/11/11 16:54:00, xidachen wrote:
> Do we need to include this header here?

Done.

[commit-bot: I haz the power, 2016-11-11 22:09:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-11 22:21:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-11 22:21:49]

Dry run: Try jobs failed on following builders:
  blimp_linux_dbg on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/blimp_linux_dbg...)
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[Justin Novosad, 2016-11-14 16:49:26]

The CQ bit was checked by junov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-14 16:49:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-14 18:18:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-14 18:18:03]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Justin Novosad, 2016-11-14 18:24:09]

The CQ bit was checked by junov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-14 18:25:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[xlai (Olivia), 2016-11-14 18:58:26]

I check the logic flow and they lgtm me. 
Please fix the compilation and the layout test then.

https://codereview.chromium.org/2493673002/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp (left):

https://codereview.chromium.org/2493673002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp:687:
exceptionState.throwDOMException(InvalidStateError,
you may want to rebaseline OffscreenCanvas-transferControlToOffscreen.html.

[Justin Novosad, 2016-11-14 19:03:42]

On 2016/11/14 18:58:26, xlai (Olivia) wrote:
> I check the logic flow and they lgtm me. 
> Please fix the compilation and the layout test then.

Done.
> 
>
https://codereview.chromium.org/2493673002/diff/80001/third_party/WebKit/Sour...
> File third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp (left):
> 
>
https://codereview.chromium.org/2493673002/diff/80001/third_party/WebKit/Sour...
> third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp:687:
> exceptionState.throwDOMException(InvalidStateError,
> you may want to rebaseline OffscreenCanvas-transferControlToOffscreen.html.

In the latest Patch set, I just removed the part of that test that was failing:
It is no longer true that toBlob and toDataURL throw on placeholder canvases,
and the new test OffscreenCanvas-placeholder-image-source.html already provides
the necessary test coverage.

Will wait for Xida's comments before committing.

[xidachen, 2016-11-14 19:05:03]

https://codereview.chromium.org/2493673002/diff/120001/third_party/WebKit/Sou...
File third_party/WebKit/Source/platform/graphics/Image.h (right):

https://codereview.chromium.org/2493673002/diff/120001/third_party/WebKit/Sou...
third_party/WebKit/Source/platform/graphics/Image.h:87: virtual void transfer()
{}
I am not sure why this function is moved from StaticBitmapImage to Image. The
StaticBitmapImage should be the only class that is transferable.

[Justin Novosad, 2016-11-14 19:08:34]

On 2016/11/14 19:05:03, xidachen wrote:
>
https://codereview.chromium.org/2493673002/diff/120001/third_party/WebKit/Sou...
> File third_party/WebKit/Source/platform/graphics/Image.h (right):
> 
>
https://codereview.chromium.org/2493673002/diff/120001/third_party/WebKit/Sou...
> third_party/WebKit/Source/platform/graphics/Image.h:87: virtual void
transfer()
> {}
> I am not sure why this function is moved from StaticBitmapImage to Image. The
> StaticBitmapImage should be the only class that is transferable.

It is to avoid having to do a typecheck+downcast in
OffscreenCanvasPlaceholder::releasePlaceholderFrame()
OffscreenCanvasPlaceholder was designed to be generic, so it uses blink::Image

[xidachen, 2016-11-14 19:09:20]

On 2016/11/14 19:08:34, Justin Novosad wrote:
> On 2016/11/14 19:05:03, xidachen wrote:
> >
>
https://codereview.chromium.org/2493673002/diff/120001/third_party/WebKit/Sou...
> > File third_party/WebKit/Source/platform/graphics/Image.h (right):
> > 
> >
>
https://codereview.chromium.org/2493673002/diff/120001/third_party/WebKit/Sou...
> > third_party/WebKit/Source/platform/graphics/Image.h:87: virtual void
> transfer()
> > {}
> > I am not sure why this function is moved from StaticBitmapImage to Image.
The
> > StaticBitmapImage should be the only class that is transferable.
> 
> It is to avoid having to do a typecheck+downcast in
> OffscreenCanvasPlaceholder::releasePlaceholderFrame()
> OffscreenCanvasPlaceholder was designed to be generic, so it uses blink::Image

That makes sense. lgtm on the latest patch.

[Justin Novosad, 2016-11-14 19:10:09]

The CQ bit was unchecked by junov@chromium.org

[Justin Novosad, 2016-11-14 19:10:15]

The CQ bit was checked by junov@chromium.org

[commit-bot: I haz the power, 2016-11-14 19:12:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-14 19:34:49]

The CQ bit was unchecked by commit-bot@chromium.org

[Justin Novosad, 2016-11-14 19:34:50]

Description was changed from

==========
Synchronize OffscreenCanvas content with the placeholder canvas

This change solves the problem of propagating frames committed by
an OffscreenCanvas all the way to the placeholder canvas, whether it
be in the same script context or not.

This allows the placeholder canvas to be used as an image source,
and to be printed.

BUG=655278
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Synchronize OffscreenCanvas content with the placeholder canvas

This change solves the problem of propagating frames committed by
an OffscreenCanvas all the way to the placeholder canvas, whether it
be in the same script context or not.

This allows the placeholder canvas to be used as an image source,
and to be printed.

BUG=655278
TBR=kbr@chromium.org, haraken@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[commit-bot: I haz the power, 2016-11-14 19:34:51]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Justin Novosad, 2016-11-14 19:36:44]

Added kbr and haraken as TBR for trivial changes in modules/webgl and bindings.

[Justin Novosad, 2016-11-14 19:36:54]

The CQ bit was checked by junov@chromium.org

[commit-bot: I haz the power, 2016-11-14 19:38:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[haraken, 2016-11-14 19:41:26]

modules/ rs LGTM

[Justin Novosad, 2016-11-14 20:46:42]

Description was changed from

==========
Synchronize OffscreenCanvas content with the placeholder canvas

This change solves the problem of propagating frames committed by
an OffscreenCanvas all the way to the placeholder canvas, whether it
be in the same script context or not.

This allows the placeholder canvas to be used as an image source,
and to be printed.

BUG=655278
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Synchronize OffscreenCanvas content with the placeholder canvas

This change solves the problem of propagating frames committed by
an OffscreenCanvas all the way to the placeholder canvas, whether it
be in the same script context or not.

This allows the placeholder canvas to be used as an image source,
and to be printed.

BUG=655278
TBR=kbr@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Justin Novosad, 2016-11-14 20:47:05]

The CQ bit was unchecked by junov@chromium.org

[Justin Novosad, 2016-11-14 20:47:12]

The CQ bit was checked by junov@chromium.org

[commit-bot: I haz the power, 2016-11-14 20:47:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-14 23:14:13]

Description was changed from

==========
Synchronize OffscreenCanvas content with the placeholder canvas

This change solves the problem of propagating frames committed by
an OffscreenCanvas all the way to the placeholder canvas, whether it
be in the same script context or not.

This allows the placeholder canvas to be used as an image source,
and to be printed.

BUG=655278
TBR=kbr@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Synchronize OffscreenCanvas content with the placeholder canvas

This change solves the problem of propagating frames committed by
an OffscreenCanvas all the way to the placeholder canvas, whether it
be in the same script context or not.

This allows the placeholder canvas to be used as an image source,
and to be printed.

BUG=655278
TBR=kbr@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[commit-bot: I haz the power, 2016-11-14 23:14:15]

Committed patchset #7 (id:120001)

[commit-bot: I haz the power, 2016-11-14 23:22:49]

Description was changed from

==========
Synchronize OffscreenCanvas content with the placeholder canvas

This change solves the problem of propagating frames committed by
an OffscreenCanvas all the way to the placeholder canvas, whether it
be in the same script context or not.

This allows the placeholder canvas to be used as an image source,
and to be printed.

BUG=655278
TBR=kbr@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Synchronize OffscreenCanvas content with the placeholder canvas

This change solves the problem of propagating frames committed by
an OffscreenCanvas all the way to the placeholder canvas, whether it
be in the same script context or not.

This allows the placeholder canvas to be used as an image source,
and to be printed.

BUG=655278
TBR=kbr@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/20ba52f0f6249c418d90244e3b7b1d8b317c30a4
Cr-Commit-Position: refs/heads/master@{#431953}
==========

[commit-bot: I haz the power, 2016-11-14 23:22:51]

Patchset 7 (id:??) landed as
https://crrev.com/20ba52f0f6249c418d90244e3b7b1d8b317c30a4
Cr-Commit-Position: refs/heads/master@{#431953}