third_party/WebKit/Source/modules/offscreencanvas2d/OffscreenCanvasRenderingContext2D.cpp - Issue 2493673002: Synchronize OffscreenCanvas content with the placeholder canvas

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/offscreencanvas2d/OffscreenCanvasRenderingContext2D.cpp

Issue 2493673002: Synchronize OffscreenCanvas content with the placeholder canvas (Closed)

Patch Set: fix obsolete test Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/canvas/HTMLCanvasElementModuleTest.cpp ('k') | third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp » ('j') | third_party/WebKit/Source/platform/graphics/Image.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/offscreencanvas2d/OffscreenCanvasRenderingContext2D.cpp

diff --git a/third_party/WebKit/Source/modules/offscreencanvas2d/OffscreenCanvasRenderingContext2D.cpp b/third_party/WebKit/Source/modules/offscreencanvas2d/OffscreenCanvasRenderingContext2D.cpp

index 72000926bf2f48aeef54bd80c41870358ee995d4..4599d147eaff4bf69836dff08758138327d80ca2 100644

--- a/third_party/WebKit/Source/modules/offscreencanvas2d/OffscreenCanvasRenderingContext2D.cpp

+++ b/third_party/WebKit/Source/modules/offscreencanvas2d/OffscreenCanvasRenderingContext2D.cpp

@@ -49,7 +49,7 @@ void OffscreenCanvasRenderingContext2D::commit(ScriptState* scriptState,

ExceptionState& exceptionState) {

UseCounter::Feature feature = UseCounter::OffscreenCanvasCommit2D;

UseCounter::count(scriptState->getExecutionContext(), feature);

- if (getOffscreenCanvas()->getAssociatedCanvasId() < 0) {

+ if (!getOffscreenCanvas()->hasPlaceholderCanvas()) {

// If an OffscreenCanvas has no associated canvas Id, it indicates that

// it is not an OffscreenCanvas created by transfering control from html

// canvas.