third_party/WebKit/Source/modules/canvas/HTMLCanvasElementModule.cpp - Issue 2493673002: Synchronize OffscreenCanvas content with the placeholder canvas

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/canvas/HTMLCanvasElementModule.cpp

Issue 2493673002: Synchronize OffscreenCanvas content with the placeholder canvas (Closed)

Patch Set: fix obsolete test Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/offscreencanvas/OffscreenCanvas.cpp ('k') | third_party/WebKit/Source/modules/canvas/HTMLCanvasElementModuleTest.cpp » ('j') | third_party/WebKit/Source/platform/graphics/Image.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/canvas/HTMLCanvasElementModule.cpp

diff --git a/third_party/WebKit/Source/modules/canvas/HTMLCanvasElementModule.cpp b/third_party/WebKit/Source/modules/canvas/HTMLCanvasElementModule.cpp

index 5d444a088941ffe61fe8dfee51798f4a155c0ec3..3345b84017aa8faf2c396eca7f77fe65783a2e77 100644

--- a/third_party/WebKit/Source/modules/canvas/HTMLCanvasElementModule.cpp

+++ b/third_party/WebKit/Source/modules/canvas/HTMLCanvasElementModule.cpp

@@ -65,7 +65,10 @@ OffscreenCanvas* HTMLCanvasElementModule::transferControlToOffscreenInternal(

}

OffscreenCanvas* offscreenCanvas =

OffscreenCanvas::create(canvas.width(), canvas.height());

- offscreenCanvas->setAssociatedCanvasId(DOMNodeIds::idForNode(&canvas));

+ int canvasId = DOMNodeIds::idForNode(&canvas);

+ offscreenCanvas->setPlaceholderCanvasId(canvasId);

+ canvas.registerPlaceholder(canvasId);

CanvasSurfaceLayerBridge* bridge = canvas.surfaceLayerBridge();

if (bridge) {