third_party/WebKit/LayoutTests/printing/offscreencanvas-2d-printing.html - Issue 2493673002: Synchronize OffscreenCanvas content with the placeholder canvas

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/printing/offscreencanvas-2d-printing.html

Issue 2493673002: Synchronize OffscreenCanvas content with the placeholder canvas (Closed)

Patch Set: build fix Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <canvas id='c'></canvas>

	3 <script>

	4 var can = document.getElementById('c');

	5 can.width = can.height = 100;

	6 var ctx = can.transferControlToOffscreen().getContext("2d");

	7 ctx.fillStyle = 'green';

	8 ctx.fillRect(0, 0, 100, 100);

	9 ctx.commit();
	xlai (Olivia) 2016/11/11 16:28:33 Great. Although the compositorFrame submmitted to Great. Although the compositorFrame submmitted to browser is still not processed in layout tests, at least after this CL we can retrieve the image information on the main thread. Justin Novosad 2016/11/11 22:09:00 This test only aims to test printing, what happens Show quoted text On 2016/11/11 16:28:33, xlai (Olivia) wrote: > Great. Although the compositorFrame submmitted to browser is still not processed > in layout tests, at least after this CL we can retrieve the image information on > the main thread. This test only aims to test printing, what happens with the browser compositor is of no consequence for this particular case. Printing happens entirely in the renderer.
	10 if (window.testRunner) {

	11 testRunner.setPrinting();

	12 testRunner.waitUntilDone();

	13 setTimeout(function() {

	14 // The setTimeout is a synchronization barrier that guarantees

	15 // the commit will be processed by the event loop before the test

	16 // is done.

	17 testRunner.notifyDone();

	18 }, 0);

	19 }

	20 </script>

OLD	NEW