third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp - Issue 2493673002: Synchronize OffscreenCanvas content with the placeholder canvas

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp

Issue 2493673002: Synchronize OffscreenCanvas content with the placeholder canvas (Closed)

Patch Set: fix obsolete test Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/offscreencanvas2d/OffscreenCanvasRenderingContext2D.cpp ('k') | third_party/WebKit/Source/platform/BUILD.gn » ('j') | third_party/WebKit/Source/platform/graphics/Image.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp

diff --git a/third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp b/third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp

index ca13517d9d8e67ef81a1db32ef5e8b1652581d42..4ce88f62e72c6612e4e2afe909608ca2978aa8ac 100644

--- a/third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp

+++ b/third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp

@@ -700,7 +700,7 @@ void WebGLRenderingContextBase::commit(ScriptState* scriptState,

return;

}

// no HTMLCanvas associated, thrown InvalidStateError

- if (getOffscreenCanvas()->getAssociatedCanvasId() == -1) {

+ if (!getOffscreenCanvas()->hasPlaceholderCanvas()) {

exceptionState.throwDOMException(InvalidStateError,

"Commit() was called on a context whose "

"OffscreenCanvas is not associated with a "