Revert of Makes the component installers return a Result instead of a bool.

Revert of Makes the component installers return a Result instead of a bool. (patchset #1 id:1 of https://codereview.chromium.org/2479633003/ )

Reason for revert:
Breaks official build.

http://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Mac/builds/15483

FAILED: obj/chrome/browser/browser/pepper_flash_component_installer.o
/b/c/cipd/goma/gomacc ../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF obj/chrome/...-inlines-hidden -std=c++11 -stdlib=libc++ -fno-rtti -fno-exceptions -c ../../chrome/browser/component_updater/pepper_flash_component_installer.cc -o obj/chrome/browser/browser/pepper_flash_component_installer.o
../../chrome/browser/component_updater/pepper_flash_component_installer.cc:162:8: error: virtual function 'OnCustomInstall' has a different return type ('bool') than the function it overrides (which has return type 'update_client::CrxInstaller::Result')
  bool OnCustomInstall(const base::DictionaryValue& manifest,
  ~~~~ ^
../../components/component_updater/default_component_installer.h:61:47: note: overridden virtual function is here
  virtual update_client::CrxInstaller::Result OnCustomInstall(
          ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^
1 error generated.

Original issue's description:
> Makes the component installers return a Result instead of a bool.
>
> This allows conveying more error information from the component
> installers to other layers of the component updater.
>
> Before this change, the component install execution path could
> only return one error. We are trying to understand the reasons
> why the component installers fail.
>
> BUG=615669
>
> Committed: https://crrev.com/73769a84d74113a4a10e4152e63d219eb72f2630
> Cr-Commit-Position: refs/heads/master@{#429995}

TBR=waffles@chromium.org,agl@chromium.org,asargent@chromium.org,sdefresne@chromium.org,pastarmovj@google.com,pastarmovj@chromium.org,sorin@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=615669
Committed: https://crrev.com/dbbd35e36767126cd0632d4a4abb521f7efc8eb2
Cr-Commit-Position: refs/heads/master@{#430008}

[Avi (use Gerrit), 2016-11-04 20:44:26]

The CQ bit was checked by avi@chromium.org

[Avi (use Gerrit), 2016-11-04 20:44:27]

Created Revert of Makes the component installers return a Result instead of a
bool.

[commit-bot: I haz the power, 2016-11-04 20:45:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-04 20:46:47]

Description was changed from

==========
Revert of Makes the component installers return a Result instead of a bool.
(patchset #1 id:1 of https://codereview.chromium.org/2479633003/ )

Reason for revert:
Breaks official build.

http://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Mac/bu...

FAILED: obj/chrome/browser/browser/pepper_flash_component_installer.o 
/b/c/cipd/goma/gomacc ../../third_party/llvm-build/Release+Asserts/bin/clang++
-MMD -MF obj/chrome/...-inlines-hidden -std=c++11 -stdlib=libc++ -fno-rtti
-fno-exceptions -c
../../chrome/browser/component_updater/pepper_flash_component_installer.cc -o
obj/chrome/browser/browser/pepper_flash_component_installer.o
../../chrome/browser/component_updater/pepper_flash_component_installer.cc:162:8:
error: virtual function 'OnCustomInstall' has a different return type ('bool')
than the function it overrides (which has return type
'update_client::CrxInstaller::Result')
  bool OnCustomInstall(const base::DictionaryValue& manifest,
  ~~~~ ^
../../components/component_updater/default_component_installer.h:61:47: note:
overridden virtual function is here
  virtual update_client::CrxInstaller::Result OnCustomInstall(
          ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^
1 error generated.


Original issue's description:
> Makes the component installers return a Result instead of a bool.
> 
> This allows conveying more error information from the component
> installers to other layers of the component updater.
> 
> Before this change, the component install execution path could
> only return one error. We are trying to understand the reasons
> why the component installers fail.
> 
> BUG=615669
> 
> Committed: https://crrev.com/73769a84d74113a4a10e4152e63d219eb72f2630
> Cr-Commit-Position: refs/heads/master@{#429995}

TBR=waffles@chromium.org,agl@chromium.org,asargent@chromium.org,sdefresne@chr...
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=615669
==========

to

==========
Revert of Makes the component installers return a Result instead of a bool.
(patchset #1 id:1 of https://codereview.chromium.org/2479633003/ )

Reason for revert:
Breaks official build.

http://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Mac/bu...

FAILED: obj/chrome/browser/browser/pepper_flash_component_installer.o 
/b/c/cipd/goma/gomacc ../../third_party/llvm-build/Release+Asserts/bin/clang++
-MMD -MF obj/chrome/...-inlines-hidden -std=c++11 -stdlib=libc++ -fno-rtti
-fno-exceptions -c
../../chrome/browser/component_updater/pepper_flash_component_installer.cc -o
obj/chrome/browser/browser/pepper_flash_component_installer.o
../../chrome/browser/component_updater/pepper_flash_component_installer.cc:162:8:
error: virtual function 'OnCustomInstall' has a different return type ('bool')
than the function it overrides (which has return type
'update_client::CrxInstaller::Result')
  bool OnCustomInstall(const base::DictionaryValue& manifest,
  ~~~~ ^
../../components/component_updater/default_component_installer.h:61:47: note:
overridden virtual function is here
  virtual update_client::CrxInstaller::Result OnCustomInstall(
          ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^
1 error generated.


Original issue's description:
> Makes the component installers return a Result instead of a bool.
> 
> This allows conveying more error information from the component
> installers to other layers of the component updater.
> 
> Before this change, the component install execution path could
> only return one error. We are trying to understand the reasons
> why the component installers fail.
> 
> BUG=615669
> 
> Committed: https://crrev.com/73769a84d74113a4a10e4152e63d219eb72f2630
> Cr-Commit-Position: refs/heads/master@{#429995}

TBR=waffles@chromium.org,agl@chromium.org,asargent@chromium.org,sdefresne@chr...
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=615669
==========

[commit-bot: I haz the power, 2016-11-04 20:46:48]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-11-04 20:49:31]

Description was changed from

==========
Revert of Makes the component installers return a Result instead of a bool.
(patchset #1 id:1 of https://codereview.chromium.org/2479633003/ )

Reason for revert:
Breaks official build.

http://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Mac/bu...

FAILED: obj/chrome/browser/browser/pepper_flash_component_installer.o 
/b/c/cipd/goma/gomacc ../../third_party/llvm-build/Release+Asserts/bin/clang++
-MMD -MF obj/chrome/...-inlines-hidden -std=c++11 -stdlib=libc++ -fno-rtti
-fno-exceptions -c
../../chrome/browser/component_updater/pepper_flash_component_installer.cc -o
obj/chrome/browser/browser/pepper_flash_component_installer.o
../../chrome/browser/component_updater/pepper_flash_component_installer.cc:162:8:
error: virtual function 'OnCustomInstall' has a different return type ('bool')
than the function it overrides (which has return type
'update_client::CrxInstaller::Result')
  bool OnCustomInstall(const base::DictionaryValue& manifest,
  ~~~~ ^
../../components/component_updater/default_component_installer.h:61:47: note:
overridden virtual function is here
  virtual update_client::CrxInstaller::Result OnCustomInstall(
          ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^
1 error generated.


Original issue's description:
> Makes the component installers return a Result instead of a bool.
> 
> This allows conveying more error information from the component
> installers to other layers of the component updater.
> 
> Before this change, the component install execution path could
> only return one error. We are trying to understand the reasons
> why the component installers fail.
> 
> BUG=615669
> 
> Committed: https://crrev.com/73769a84d74113a4a10e4152e63d219eb72f2630
> Cr-Commit-Position: refs/heads/master@{#429995}

TBR=waffles@chromium.org,agl@chromium.org,asargent@chromium.org,sdefresne@chr...
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=615669
==========

to

==========
Revert of Makes the component installers return a Result instead of a bool.
(patchset #1 id:1 of https://codereview.chromium.org/2479633003/ )

Reason for revert:
Breaks official build.

http://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Mac/bu...

FAILED: obj/chrome/browser/browser/pepper_flash_component_installer.o
/b/c/cipd/goma/gomacc ../../third_party/llvm-build/Release+Asserts/bin/clang++
-MMD -MF obj/chrome/...-inlines-hidden -std=c++11 -stdlib=libc++ -fno-rtti
-fno-exceptions -c
../../chrome/browser/component_updater/pepper_flash_component_installer.cc -o
obj/chrome/browser/browser/pepper_flash_component_installer.o
../../chrome/browser/component_updater/pepper_flash_component_installer.cc:162:8:
error: virtual function 'OnCustomInstall' has a different return type ('bool')
than the function it overrides (which has return type
'update_client::CrxInstaller::Result')
  bool OnCustomInstall(const base::DictionaryValue& manifest,
  ~~~~ ^
../../components/component_updater/default_component_installer.h:61:47: note:
overridden virtual function is here
  virtual update_client::CrxInstaller::Result OnCustomInstall(
          ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^
1 error generated.

Original issue's description:
> Makes the component installers return a Result instead of a bool.
>
> This allows conveying more error information from the component
> installers to other layers of the component updater.
>
> Before this change, the component install execution path could
> only return one error. We are trying to understand the reasons
> why the component installers fail.
>
> BUG=615669
>
> Committed: https://crrev.com/73769a84d74113a4a10e4152e63d219eb72f2630
> Cr-Commit-Position: refs/heads/master@{#429995}

TBR=waffles@chromium.org,agl@chromium.org,asargent@chromium.org,sdefresne@chr...
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=615669

Committed: https://crrev.com/dbbd35e36767126cd0632d4a4abb521f7efc8eb2
Cr-Commit-Position: refs/heads/master@{#430008}
==========

[commit-bot: I haz the power, 2016-11-04 20:49:32]

Patchset 1 (id:??) landed as
https://crrev.com/dbbd35e36767126cd0632d4a4abb521f7efc8eb2
Cr-Commit-Position: refs/heads/master@{#430008}