Revert of Makes the component installers return a Result instead of a bool.

components/component_updater/default_component_installer.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_COMPONENT_UPDATER_DEFAULT_COMPONENT_INSTALLER_H_
 #define COMPONENTS_COMPONENT_UPDATER_DEFAULT_COMPONENT_INSTALLER_H_
 
 #include <stdint.h>
 
 #include <memory>
@@ skipping 40 matching lines @@
   virtual bool SupportsGroupPolicyEnabledComponentUpdates() const = 0;
 
   // Returns true if the network communication related to this component
   // must be encrypted.
   virtual bool RequiresNetworkEncryption() const = 0;
 
   // OnCustomInstall is called during the installation process. Components that
   // require custom installation operations should implement them here.
   // Returns false if a custom operation failed, and true otherwise.
   // Called only from a thread belonging to a blocking thread pool.
-  virtual update_client::CrxInstaller::Result OnCustomInstall(
-      const base::DictionaryValue& manifest,
-      const base::FilePath& install_dir) = 0;
+  virtual bool OnCustomInstall(const base::DictionaryValue& manifest,
+                               const base::FilePath& install_dir) = 0;
 
   // ComponentReady is called in two cases:
   //   1) After an installation is successfully completed.
   //   2) During component registration if the component is already installed.
   // In both cases the install is verified before this is called. This method
   // is guaranteed to be called before any observers of the component are
   // notified of a successful install, and is meant to support follow-on work
   // such as updating paths elsewhere in Chrome. Called on the UI thread.
   // |version| is the version of the component.
   // |install_dir| is the path to the install directory for this version.
@@ skipping 35 matching lines @@
   DefaultComponentInstaller(
       std::unique_ptr<ComponentInstallerTraits> installer_traits);
 
   // Registers the component for update checks and installs.
   // The passed |callback| will be called once the initial check for installed
   // versions is done and the component has been registered.
   void Register(ComponentUpdateService* cus, const base::Closure& callback);
 
   // Overridden from ComponentInstaller:
   void OnUpdateError(int error) override;
-  update_client::CrxInstaller::Result Install(
-      const base::DictionaryValue& manifest,
-      const base::FilePath& unpack_path) override;
+  bool Install(const base::DictionaryValue& manifest,
+               const base::FilePath& unpack_path) override;
   bool GetInstalledFile(const std::string& file,
                         base::FilePath* installed_file) override;
   // Only user-level component installations can be uninstalled.
   bool Uninstall() override;
 
  private:
   ~DefaultComponentInstaller() override;
 
   // If there is a installation of the component set up alongside Chrome's
   // files (as opposed to in the user data directory), sets current_* to the
   // values associated with that installation and returns true; otherwise,
   // returns false.
   bool FindPreinstallation(const base::FilePath& root);
-  update_client::CrxInstaller::Result InstallHelper(
-      const base::DictionaryValue& manifest,
-      const base::FilePath& unpack_path,
-      const base::FilePath& install_path);
+  bool InstallHelper(const base::DictionaryValue& manifest,
+                     const base::FilePath& unpack_path,
+                     const base::FilePath& install_path);
   void StartRegistration(ComponentUpdateService* cus);
   void FinishRegistration(ComponentUpdateService* cus,
                           const base::Closure& callback);
   void ComponentReady(std::unique_ptr<base::DictionaryValue> manifest);
   void UninstallOnTaskRunner();
 
   base::FilePath current_install_dir_;
   base::Version current_version_;
   std::string current_fingerprint_;
   std::unique_ptr<base::DictionaryValue> current_manifest_;
   std::unique_ptr<ComponentInstallerTraits> installer_traits_;
   scoped_refptr<base::SequencedTaskRunner> task_runner_;
 
   // Used to post responses back to the main thread. Initialized on the main
   // loop but accessed from the task runner.
   scoped_refptr<base::SingleThreadTaskRunner> main_task_runner_;
 
   base::ThreadChecker thread_checker_;
 
   DISALLOW_COPY_AND_ASSIGN(DefaultComponentInstaller);
 };
 
 }  // namespace component_updater
 
 #endif  // COMPONENTS_COMPONENT_UPDATER_DEFAULT_COMPONENT_INSTALLER_H_